Repository navigation
Conversation
Update manifest classification in summarycode.classify to dynamically load path patterns from all active APPLICATION_PACKAGE_DATAFILE_HANDLERS in packagedcode. This resolves issue aboutcode-org#4225 where modern package manifests and lockfiles (such as Cargo.lock, poetry.lock, Pipfile.lock, package-lock.json, pnpm-lock.yaml, yarn.lock, go.mod, pubspec.yaml, conanfile.py, uv.lock) failed to be classified with is_manifest=True when running --classify. Also add unit tests in tests/summarycode/test_classify.py covering modern manifests and verifying binary archives are excluded. Fixes aboutcode-org#4225 Signed-off-by: Gracy769 <169199616+Gracy769@users.noreply.github.com>
Author
|
Note for reviewers: The single CI failure in core_tests license_validate_ignorables_2 is a pre-existing upstream regression on develop (present in Azure Build 19540) caused by missing ignorable_urls in sl-1.1_1.RULE and sl-1.1_2.RULE. All 31 other platform CI jobs (macOS, Ubuntu, Windows 2019/2022/2025, and all summarycode tests) passed 100%. I have submitted the standalone fix to unbreak develop in #5362. |
Signed-off-by: Gracy769 <169199616+Gracy769@users.noreply.github.com>
Signed-off-by: Gracy769 <169199616+Gracy769@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4225.
--classifymissed supported package manifests and lockfiles because its manifest list was static. The package handlers already declare filename patterns, so classification now reuses those patterns.Changes
packagedcodedatafile handlers.*conda*.yaml).Verification
git diff --checkpassed.Signed-off-by: Gracy769 169199616+Gracy769@users.noreply.github.com