Repository navigation
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/cluster/database_event_stream.py | 92.86% | 96.94% | 🟢 +4.08% |
| src/a2a/server/routes/rest_routes.py | 83.33% | 84.38% | 🟢 +1.04% |
| Total | 92.99% | 93.03% | 🟢 +0.04% |
Generated by coverage-comment.yml
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
create_rest_routesmounted the tenant routes at/{tenant}over routes that already includepath_prefix, so with a prefix they were served at/{tenant}{path_prefix}/.... The SDK's REST client sends{path_prefix}/{tenant}/..., so every tenant-scoped request got a 404. This mounts the tenant routes at{path_prefix}/{tenant}over unprefixed routes instead. Without a prefix the routes are the same as before.A server that sets
path_prefixno longer answers tenant requests at/{tenant}{path_prefix}/.... The SDK's REST client doesn't send requests there.test_rest_endpoints_routing_tenant_with_path_prefixfails on main with a 404. The full test suite passes with 93% coverage.ruffis clean andtyreports no errors.CONTRIBUTINGGuide.bash scripts/format.shfrom the repository root to format)Fixes #1376 🦕