Repository navigation
[multibyte] Encode typeidx before offset - #9222
Open
brendandahl wants to merge 2 commits into
Open
brendandahl wants to merge 2 commits into
brendandahl wants to merge 2 commits into
Conversation
The multibyte array access proposal updated the binary format of memarg to place typeidx immediately after flags and before offset (flags:u32 typeidx:u32 offset:u32), matching the position of memidx in multi-memory accesses. Update the binary reader and writer accordingly.
tlively
approved these changes
Oct 6, 2026
| if (backing == BackingType::Array) { | ||
| return {Name(), alignment, offset, backing}; | ||
| if (arrayType) { | ||
| return {Name(), alignment, offset, arrayType}; |
Member
There was a problem hiding this comment.
I wonder if using a std::variant<Name, HeapType> instead of a separate Name and std::optional<HeapType> would be any nicer. Probably not, given how gross std::variant is!
Collaborator
Author
There was a problem hiding this comment.
I tried it out, but yeah it looked more verbose. getMemarg is called in quite a few places.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multibyte array access proposal updated the binary format of memarg to place typeidx immediately after flags and before offset (flags:u32 typeidx:u32 offset:u32), matching the position of memidx in multi-memory accesses. Update the binary reader and writer accordingly.
See WebAssembly/multibyte-array-access#10