镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Inconsistency in NFT ID Handling #51

Open

Description

@myst4

Hello guys,

I am currently testing the DN404 protocol, and I've encountered inconsistencies regarding NFT IDs.
Here is the scenario:

User A and User B are participating in the protocol.
User A purchases 4 NFTs with the IDs 1, 2, 3, and 4.
User B purchases 1 NFT with the ID 5.
User A sells the NFTs with the IDs 3 and 4 as tokens on a DEX. These two IDs are burned.
User A returns to purchase another entire unit token (1 NFT) on a DEX. The new NFT is minted with the ID 6, resulting in a loss of reference to the IDs 3 and 4.

This process raises concerns about consistency in NFT ID. Shouldn't there be a mechanism in place to maintain consistency and ensure that IDs are not lost?
If I'm not mistaken, The ERC404 protocol addresses this by adding a queue for burned IDs to be minted again later, ensuring consistency with the NFT IDs

Thanks for advance

Activity

  1. Vectorized commented on Feb 14, 2024

    @Vectorized
    Owner

    This is intentional. We want to cycle through all the token Ids.

    If you want to prevent rarity sniping, make a second baseURI update after all the IDs have been cycled through once.

  2. Vectorized commented on Feb 14, 2024

    @Vectorized
    Owner

    We might make it an option in the future to allow recycling token Ids, but we have other priorities.

  3. nschwermann commented on Dec 28, 2024

    @nschwermann

    So will NFTs always be minted in order for the default behavior?

    If it has cycled through one time, currently the last token minted was token 1, If token ID 2 is sold into the DEX on the next TX, then it would be first to be minted or it is now at the back of the que and is now FIFO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions