镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Release v2026.10.17.2215 - #433

Open
POPPIN-FUMI wants to merge 2 commits into
mainfrom
release/v2026.10.17.2215
Open

POPPIN-FUMI wants to merge 2 commits into
mainfrom
release/v2026.10.17.2215

Conversation

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor

Prepares SLV v2026.10.17.2215 from the release and security changes merged in #423. Updates version references, installer and template snapshots, and the latest-template link using the existing release generator.

Fixes skill packaging when a playbook includes a nested common task: create its destination directory and merge the shared task contents without introducing a second tasks/ directory. The regression now runs the real generator and packager for all three skills and checks packaged paths and bytes.

Validation: the real-generator regression passed; the original packager and a mkdir-only counterfactual both failed at the expected checks. update-version.ts and check-version-sync.ts completed successfully for this version. The required template test vector is included in the generated snapshot.

Tracks #423.

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

Independent backend/script review of the release packager and generator regression coverage.

steiner gate claim / round 1 / 対象 42efbcd / steiner-pr433-r1-3438db24

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

Infra release review in progress.

auron gate claim / round 1 / 対象 42efbcd / auron-pr433-r1-ac3791f1

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

cyan gate claim / round 1 / 対象 42efbcd / cyan-pr433-r1-1d428dff

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steiner / round 1 / PASS

Reviewed target: 42efbcd
Base: a7f7f83

No blocking backend/script findings in this release diff. The packager now creates the parent directory before copying a nested common dependency and copies the contents of the common tasks directory into its existing destination. These two changes address separate failure modes: a missing parent and an extra tasks/tasks nesting. Quoted paths and fail-fast shell behavior are preserved. The test invokes the actual generator and actual packager for validator, RPC and gRPC Geyser, compares file membership and bytes (including nested, binary and UTF-8 fixtures), checks preservation of the source and blocked delivery tasks, and checks clean rebuild behavior and unsupported input.

Requirement evidence: on Linux, deno test --frozen --allow-read --allow-write --allow-run scripts/release/update_version_test.ts passed (1 test); bash -n build-skill.sh and deno run --frozen --allow-read scripts/check-version-sync.ts passed. Independently ran the new test in disposable fixtures against the base packager and a mkdir-only mutant using deno test --no-config --allow-read --allow-write --allow-run: both failed at the intended behavior, respectively the missing destination parent and extra tasks/another.yml hierarchy. An initial copied-workspace counterfactual stopped at lockfile validation and was excluded; the isolated no-config executions reached the actual assertions. Existing CI's release test command includes scripts/release, so this test is on its execution path.

Non-regression evidence: independently compared Git tree entries (relative names, modes, types and blob IDs): the 531 new template entries equal the retained source template at the base commit. The new installer equals the canonical installer. Inspected the version-file differences, latest symlink, KEEP_VERSIONS pruning implementation, both commit messages and PR title. The complete no-renames diff has 532 additions, 325 deletions and 7 modifications; changes outside the version snapshots are the two repair files and version metadata. No API/schema/authentication contract or workflow edit is introduced by this diff.

Limitations: this is the medium-effort first-phase domain verdict. CI was still in progress when inspected; this review does not certify CI completion, native builds, installation on real nodes or public release delivery. The existing CLI exports-extension warning remains. No deployment or production operation was performed.

Gate: steiner
Round: 1
Target: 42efbcd
Verdict: PASS
Claim: steiner-pr433-r1-3438db24
Effort: medium

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auron / round 1 — PASS (infra and release packaging, medium phase)

Target: 42efbcd
Base: a7f7f83

Requirement assessment: the release advances the canonical version, CLI manifest, template task, installer label and latest-template link to 2026.10.17.2215. The packaging repair creates the parent of nested common files, then copies task-directory contents into the existing destination, avoiding a second tasks directory. I found no blocking defect in this scope.

Non-regression evidence: independently compared Git trees from base and target: all 531 new template members have identical paths, blobs and modes to base's retained 2026.6.6.2026 template, including the floor-vector fixture. The new versioned installer equals target's canonical installer; that canonical installer's only change is the version label. The no-renames census is 532 additions, 325 deletions and 7 modifications. Deletions are confined to the 2026.5.21.1448 installer and template, consistent with the unchanged three-version retention policy. Previous retained versions remain available; this change itself performs no fleet operation. Existing installer verification and release publication controls are unchanged.

Commands/results: on the target Linux checkout, bash -n build-skill.sh passed; deno test --frozen --allow-read --allow-write --allow-run scripts/release/update_version_test.ts passed (1 test). The test executes the real generator and three-skill packager, compares nested/common and skill-specific bytes, checks repeated-build cleanup and rejects unsupported skills. I also read the supplied mkdir-only negative-control failure at the directory-inventory assertion: the control detects the duplicate nested tasks defect. I inspected the complete two commit messages and PR title, the generator call sites, and the existing pull-request release workflow: its release test command includes scripts/release, reaching this regression test. No workflow or workflow-generator definition changes are present. git diff --check reports whitespace copied unchanged from the retained template; no authored packaging-source whitespace failure was found.

Limits: CI is still running; this verdict does not assert completion of required checks or native platform builds. I did not perform a native rebuild, release publication, remote installation, live Ansible execution, or platform runtime validation. The pre-existing CLI exports-extension warning appeared during the passing test. This is the medium-phase domain verdict, not final merge clearance.

Gate: auron
Round: 1
Target: 42efbcd
Verdict: PASS
Claim: auron-pr433-r1-ac3791f1
Effort: medium

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyan independent review: PASS for the reviewed source change; no blocking finding.

Target: 42efbcd. Baseline: a7f7f83 on main. I inspected the actual diff, both commit messages, release title, generator, skill packager, test implementation, installer delta, and existing release workflow/resolver.

Requirements: the packager now creates nested destination parents and merges common-task directory contents into the destination. The test invokes the real packager through update-version for validator, rpc, and grpc-geyser, and checks complete task trees/bytes, nested dependencies, repeated-build cleanup, and unsupported input. Reach is established by that real invocation and the workflow's scripts/release test selection. Firing evidence includes the supplied mkdir-only counterfactual log, whose task-tree equality assertion rejects an extra tasks/tasks subtree. That counterfactual was inspected, not rerun by this reviewer.

Independent validation on Linux with Deno 2.9.3: deno test --frozen -A scripts/release/update_version_test.ts passed (1 test); deno task check:version-sync passed; bash -n build-skill.sh passed. A Git-object census using git ls-tree -r independently compared all 531 generated template members against template/2026.6.6.2026: names, blob identities and modes match. git diff --no-renames --name-status yielded 532 additions, 325 deletions and 7 modifications, consistent with the version rotation plus two repair files. cmp sh/install sh/2026.10.17.2215/install passed. The working tree remained clean.

Non-regression: version labels, the template task and latest symlink agree; the deleted old generation follows the unchanged three-version retention rule. The installer changes only its version label relative to the baseline canonical installer. Delivery restrictions and component versions are unchanged. git diff --check reports inherited whitespace in the byte-identical copied templates; the existing CLI exports warning also remains. Neither is introduced behavior in this release repair. The commit subjects and PR title describe stable changes without claiming production success.

Release effect and remaining verification: the existing main-push resolver detects this version advance and enters the release pipeline. Merging is therefore release-significant. I did not run native builds, publish assets, install a release, or verify live delivery/rollback. GitHub checks were still pending when inspected; this review does not certify CI completion. Independent domain verdicts and required CI remain separate acceptance inputs. This is the requested medium review phase, not the final-effort merge receipt.

Gate: cyan
Round: 1
Target: 42efbcd
Verdict: PASS
Claim: cyan-pr433-r1-1d428dff
Effort: medium

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

Independent backend and packaging confirmation for the current release diff.

steiner gate claim / round 2 / 対象 42efbcd / steiner-pr433-r2-f6d93297

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

Independent infra and release-packaging confirmation of the specified head.

auron gate claim / round 2 / 対象 42efbcd / auron-pr433-r2-c5b82f16

@POPPIN-FUMI

Copy link
Copy Markdown
Contributor Author

Cyan round 2 independent final review is in progress.

cyan gate claim / round 2 / 対象 42efbcd / cyan-pr433-r2-1c7ff134

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS — Steiner backend/packaging confirmation, round 2.

Target: 42efbcd
Base: a7f7f83

Independently reviewed the complete source/test change, generated release inventory, release title and both commit messages. No blocking finding in the reviewed backend/packaging scope.

Requirement: build-skill.sh now creates the parent directory before copying a nested common dependency and merges the contents of cmn/tasks into its existing destination. The real generator regression exercises validator, rpc and grpc-geyser packages, direct/transitive common files, nested tasks, binary/UTF-8 content, common Jinja files, repeat-build equality, stale-file removal and unsupported-skill rejection. The test calls the repository packager through scripts/update-version.ts; the release workflow includes this test directory.

Non-regression: an independent Git-object census compared the new template against both the retained head template and its base version. All 531 member names, modes, object types and blob identities match. This includes tests/alpenglow_floor_vectors.json (17,026 bytes; SHA-256 762f7b7e63edeaa2eec51d13efdf14955a3ba0e39a8efde3a0132b185ce1defd). The new installer equals sh/install; changes to the canonical installer and component-constants file are limited to the SLV version label. JSON semantic comparisons confirmed only the CLI version and create:template target changed. template/latest and the three retained version directories agree with the existing KEEP_VERSIONS policy. The 325 deleted paths are confined to the old 2026.5.21.1448 template and installer. No API, DB, authorization or dependency contract changed in this diff.

Executed on Linux x86_64 with Deno 2.9.3:

  • deno test --frozen --allow-read --allow-write --allow-run scripts/release/update_version_test.ts: 1 passed, 0 failed.
  • Ran the same current regression in isolated fixtures with the base packager and with only the parent-directory fix: both failed as expected. The base failed at the missing nested destination; the partial fix failed tree equality because of tasks/tasks nesting. These controls establish both failure detection and reach through the generator.
  • deno run --frozen --allow-read scripts/check-version-sync.ts: passed.
  • bash -n for build-skill.sh and both installer copies: passed. Source/version-file git diff --check passed; full-diff whitespace notices are inherited from the byte-identical copied template. The existing CLI exports warning also remains unchanged. The reviewed checkout is clean.

Limits: Actions run 39075850168 at this target had successful resolve/test jobs while source-materials was still running when checked. This verdict does not establish completion of required CI, native-platform execution, artifact publication or public installation verification; those remain release/merge prerequisites as applicable.

Gate: steiner
Round: 2
Target: 42efbcd
Verdict: PASS
Claim: steiner-pr433-r2-f6d93297
Effort: xhigh

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyan independent final confirmation: PASS for 42efbcd against main a7f7f83. This is an R3 release-path review; the separate backend and infrastructure verdicts remain required.

Requirement satisfaction: the two-file repair makes the real update-version three-skill generation path create nested common-task parents and merge task-directory contents without introducing a second tasks directory. The test now invokes the checked-in generator and packager rather than a stub. I read the repair, generator, test, version/installer changes, commit messages, PR title, and existing release resolver/package/publication path independently of earlier verdicts.

Non-regression: an independent Git-object census found 864 changed paths overall and 862 in the generated commit (532 additions, 325 deletions, 5 modifications). All 531 new template members match the landing-base template/2026.6.6.2026 by relative name, mode, type, and blob ID, including the floor-vector JSON. The retained source is unchanged. The new versioned installer matches the canonical installer byte-for-byte. JSON semantic comparison limits the configuration changes to the package version and template task target. Pruning removes the oldest version under the existing keep-three rule; the two previous versions remain. The reviewed delta does not change workflows, dependency pins, component defaults, release verification, or legacy delivery guards. Both commit messages and the PR title describe stable changes.

Commands and results, on Linux x86_64 with Deno 2.9.3 and Bash 5.2:

  • deno test --frozen --allow-read --allow-write --allow-run scripts/release/update_version_test.ts: 1 passed, 0 failed. It checks the three skills, nested/transitive tasks, binary and UTF-8 bytes, directory membership, unchanged source, repeat-build cleanup, unsupported skill failure, and preserved delivery tasks.
  • bash -n build-skill.sh and deno run --frozen --allow-read scripts/check-version-sync.ts: passed.
  • git ls-tree -rz, git diff --no-renames --name-status, and git show: supplied the object comparisons above. The worktree remained clean. Repair-only git diff --check passed; the combined check reports five existing whitespace warnings in byte-identical copied template files.

Reach: the existing workflow's test job includes scripts/release, so it executes this regression. The real update-version generator invokes build-skill.sh for all three affected skill outputs. The release packager separately consumes the versioned template, canonical installer, and existing dist/oss-skills sources; this review does not conflate those skill directories. A version advance on main enters the existing release pipeline, with its package, provenance, activation, and publication checks intact.

Firing: I independently ran the same new regression in temporary fixtures with (1) the landing-base packager and (2) the parent-directory-only repair. Both exited 1 at the expected defect: missing nested destination, then duplicated tasks-directory inventory. The target passes. Thus a repair that merely creates the parent directory would not satisfy this test.

Unverified/remaining gates: native CI run 39075850168 was still in progress when checked. I did not rerun native builds, execute a deployment, publish assets, or verify a completed public installation. The coordinating maintainer must close current-head CI and the independently returned Auron/Steiner verdicts before merge. This review is not the OSS compliance advisory or a legal certification, and it makes no claim that publication has completed.

Gate: cyan
Round: 2
Target: 42efbcd
Verdict: PASS
Claim: cyan-pr433-r2-1c7ff134
Effort: xhigh

@POPPIN-FUMI POPPIN-FUMI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS — Auron independent final confirmation, round 2.

Reviewed target 42efbcd2adc1b5663db4d885f351e724240dbd11 against base a7f7f83f43b579e515fa55a7e27eecd794032c26. This is an independent review of the current diff, both commit messages and the release title. No blocking infra or packaging finding.

Requirement: build-skill.sh creates the parent directory before copying a nested common dependency, then merges cmn/tasks/. into the existing tasks directory. This fixes both the missing-parent failure and the duplicated tasks/tasks result. The supported-skill allowlist, quoted paths, clean output directory and error propagation remain intact. Its repository caller is scripts/update-version.ts; the public release packager separately reads canonical dist/oss-skills inputs. I did not assume these two output trees were interchangeable.

Non-regression and distribution scope: an independent git diff --no-renames --name-status census found 532 additions, 325 deletions and 7 modifications. Git tree comparisons establish that all 531 new template members have identical relative names, modes and blobs to template/2026.6.6.2026 at both base and target. This includes the 249 Ansible YAML files, their existing guards, and the 17,026-byte floor-vector fixture (SHA-256 762f7b7e63edeaa2eec51d13efdf14955a3ba0e39a8efde3a0132b185ce1defd). Repository-wide playbook-stem searches include CLI, scripts, packaged skills and test callers. The version change selects the new template for consumers; it introduces no different host selectors or Ansible execution content.

The new versioned installer exactly equals sh/install; comparison with the base canonical installer changes only its VERSION label. template/latest points to 2026.10.17.2215. The unchanged KEEP_VERSIONS=3 generator removes only the tracked 2026.5.21.1448 template/installer and retains both June versions. This diff does not delete published releases. All changed paths fit the packaging repair, regression test and generated version artifacts. Workflow definitions, dependency locks, component pins and publication safeguards are unchanged.

Validation on Linux x86_64 / Deno 2.9.3: deno test --frozen --allow-read --allow-write --allow-run scripts/release/update_version_test.ts passed (1/1). The real three-skill fixture verifies nested/direct/transitive copies, binary and UTF-8 bytes, complete task inventories, repeat builds, stale-output removal and unsupported-skill rejection. I also compared the existing generated validator/RPC/gRPC skill directories against their selected source trees and common tasks: equal, without tasks/tasks. Firing evidence: the retained mkdir-only counterfactual uses byte-identical test/generator/checker inputs and fails the task-tree comparison on duplicated nesting. deno task check:version-sync, bash -n build-skill.sh and sh -n sh/install passed. git diff --check reports five inherited whitespace diagnostics in the byte-identical template copies; the existing CLI export-extension warning also persists.

CI and release effects: existing pull_request/main triggers cover this change, and the regression is reached through the existing release test job. No workflow/job/gate is added or removed. PR resolution sets release_required=false and packages CI-only payloads; a main-branch VERSION advance enters the existing release pipeline. At inspection, run 39075850168 is on the target head, its test job succeeded, and source-materials remains in progress; template tests are also still running. No completed all-native CI or published-release result is claimed. A pre-implementation workflow-intake reference was not supplied to this review and has been returned to the coordinator; the inspected trigger/guard substance presents no harmful delta.

Unverified: completion of current CI, native builds on all targets, post-merge publication/attestation/consumer installation, live fleet execution and live rollback. The existing guarded release chain must complete before claiming delivery. Full seven-day failure-root-cause analysis and end-to-end runtime delta were not remeasured in this confirmation. The bounded OSS evidence review is separately coordinated.

Gate: auron
Round: 2
Target: 42efbcd
Verdict: PASS
Claim: auron-pr433-r2-c5b82f16
Effort: xhigh

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant