镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content
This repository was archived by the owner on Dec 7, 2022. It is now read-only.
This repository was archived by the owner on Dec 7, 2022. It is now read-only.

Refactor lib/utils.js #54

Open
Open

Description

@jacobmoretti

Refactor lib/utils.js by abstracting out each of the functions into separate files and placed under lib:

  • getLocation, I believe this was only added to allow easier mocking. We should be able to do away with this and fix the tests that relied on it.
  • ldClientWrapper -> ldClientWrapper.js
  • ldOverrideFlag -> ldOverrideFlag.js
  • getAllFeatureFlags -> getAllFeatureFlags.js

Activity

  1. GarretLefler commented on Oct 29, 2017

    @GarretLefler

    I can help with this.

    Is there a quick way to test any changes I make before I submit a pull request?

  2. jacobmoretti commented on Oct 30, 2017

    @jacobmoretti
    CollaboratorAuthor

    @GarretLefler Thanks for offering to lend a hand with this issue! Unfortunately there isn't a great a way to do an end-to-end test without an account with LaunchDarkly. Its also part of the reason why #16 hasn't been completed yet.

    Feel free to submit your PR and use the unit-tests as the measurement for now. I'll do some testing of your changes on my end as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions