镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Use of instance_variable_set in testing? #1

Closed
Closed
Use of instance_variable_set in testing?#1

Description

@rlmoser99
rlmoser99
opened on Sep 11, 2020

Is using instance_variable_set a code smell, when used only in testing? For example:

Is it better to have @guess as a parameter, to be able to easily create a new instance of game for tests subject(:game) { described_class.new(0, 9, 4) }

def initialize(min, max, guess = nil)
  @min = min
  @max = max
  @guess = guess
end

Or is it better to have less arguments and to use game.instance_variable_set(:@guess, 4) in the few tests that require a value for @guess?

def initialize(min, max)
  @min = min
  @max = max
  @guess = nil
end

Activity

  1. KevinMulhern commented on Oct 30, 2020

    @KevinMulhern
    KevinMulhern
    on Oct 30, 2020
    Member

    @rlmoser99 yeah I believe that its a code smell and your solution of passing the param in during initialisation is how it should be done. It fits nicely with the open closed principle. Having to use instance_variable_set seems like a work around.

  2. rlmoser99 commented on Oct 31, 2020

    @rlmoser99
    rlmoser99
    on Oct 31, 2020
    MemberAuthor

    Awesome! Thanks for your input! It is great to know with confidence that we should not be using instance_variable_set in testing.

  3. rlmoser99
    closed this as completedon Oct 31, 2020
  4. ViperFangs
    added 2 commits that reference this issue on Jul 10, 2022

    Implement solution for Assignment TheOdinProject#1 in 15a_binary_game…

    ba3019c

    Implement solution for Assignment TheOdinProject#1 in 16a_caesar_brea…

    fdbecca
  5. dane-dalton
    added a commit that references this issue on Sep 6, 2022

    Ex. 13 Assignment TheOdinProject#1 done

    b4460cb
  6. missopi
    added 4 commits that reference this issue on Aug 18, 2023

    Complete assignment TheOdinProject#1

    8843840

    Complete assignment TheOdinProject#1 and make_guess method

    a6070c4

    Complete assignment TheOdinProject#1

    aec54e2

    Complete assignment TheOdinProject#1 & TheOdinProject#2

    b0b8bc1
  7. lohikaarme
    added 4 commits that reference this issue on Dec 4, 2023

    Complete assignment method TheOdinProject#1

    66e9d41

    Complete 15a assignment method TheOdinProject#1, partial 2

    8d36080

    Complete 15a assignment method TheOdinProject#1, partial 2

    a9b4076

    Complete 16a assignment method TheOdinProject#1 & TheOdinProject#2

    5f44d51
  8. gabriele92984
    added a commit that references this issue on May 13, 2025

    Complete assignment TheOdinProject#1 spec/13_input_output_spec.rb

    a0bd24c
  9. gabriele92984
    added 7 commits that reference this issue on Jun 9, 2025

    Write 1st failing test method TheOdinProject#1 spec/14_find_number_sp…

    5ca71e9

    Make pass 1st failing test method TheOdinProject#1 spec/14_find_numbe…

    866cd01

    Make pass 2st failing test method TheOdinProject#1 spec/14_find_numbe…

    48dd0de

    Make pass 3rd 4th 5th tests method TheOdinProject#1 spec/14_find_numb…

    f772015

    Refactor method TheOdinProject#1 tests spec/14_find_number_spec.rb

    9201903

    Complete assignment TheOdinProject#1 spec/15a_binary_game_spec.rb

    2529fb5

    Complete assignment TheOdinProject#1 spec/16a_caesar_breaker_spec.rb

    0dc3185
  10. jh80
    added 2 commits that reference this issue on Jun 21, 2025

    Complete binary game assignment TheOdinProject#1

    da7422b

    Complete ceasar breaker assignments TheOdinProject#1-TheOdinProject#4

    16b0020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions