Repository navigation
Fix Unicode text handling in DES encryption - #15640
Closed
mohammedanasnakhuda wants to merge 1 commit into
Closed
mohammedanasnakhuda wants to merge 1 commit into
mohammedanasnakhuda wants to merge 1 commit into
Conversation
Closing this pull request as invalid@mohammedanasnakhuda, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15634.
This pull request updates the DES ECB implementation to support Unicode input using UTF-8 encoding.
Previously, characters above U+00FF could produce incorrect decrypted output because the implementation converted Unicode code points into variable-width bit sequences.
Changes
Testing
git diff --checkpassed.The broader cipher test collection was blocked by a pre-existing syntax error in
maths/greatest_common_divisor.pyand missing NumPy in the local environment.Compatibility notes
UTF-8 encoding changes ciphertext representation for some previously supported non-ASCII characters. Ciphertext produced by the previous encoding may not be compatible with this change.
The existing zero-padding scheme also does not preserve trailing null characters; that limitation is outside the scope of this fix.