镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: binary_count_trailing_zeros - #14574

Closed
anup-sys wants to merge 3 commits into
TheAlgorithms:masterfrom
anup-sys:binary_count_trailing_zeros
Closed

fix: binary_count_trailing_zeros#14574
anup-sys wants to merge 3 commits into
TheAlgorithms:masterfrom
anup-sys:binary_count_trailing_zeros

Conversation

@anup-sys

@anup-sys anup-sys commented Apr 23, 2026

Copy link
Copy Markdown

…14479

Description

This PR fixes input validation in binary_count_trailing_zeros.

  • Ensures type checking is performed before comparisons
  • Prevents unintended TypeError for non-integer inputs (e.g., strings)
  • Maintains existing behavior for a == 0 (returns 0 by convention)

Type of change

  • Fix a bug or typo in an existing algorithm

Checklist

  • I have read the contributing guidelines
  • This PR is my own work
  • This PR only changes one algorithm file
  • All functions include doctests that pass

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 23, 2026
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Apr 23, 2026
@anup-sys anup-sys changed the title fix: input validation in binary_count_trailing_zeros fix: binary_count_trailing_zeros Apr 23, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Apr 23, 2026
@cclauss cclauss mentioned this pull request Sep 13, 2026
Closed
@cclauss cclauss closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mindaugl mindaugl mindaugl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anup-sys @mindaugl @cclauss