Repository navigation
Conversation
… have When an SDF CELL names an instance the netlist does not have, setInstance reports it (warning 195) and leaves instance_ null, and the cell's entries are skipped -- every handler checks instance_ except timingCheckSetupHold1, shared by SETUPHOLD and RECREM, which passed it to network_->cell() and segfaulted. Guard it as timingCheckPeriod and timingCheckWidth are guarded, including the incremental-only condition. Seen on nextpnr's SDF for a Xilinx 7-series design, whose cell names contain '/' (read as a hierarchy divider, so the instance is not found). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates SdfReader::timingCheckSetupHold1 to include a conditional check that prevents timing checks from being processed if the instance is null or if specific incremental conditions are met. I have no feedback to provide as there were no review comments.
|
|
Windows cannot run a script by its #! line, so StaTclInitVar.cc was never generated there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an SDF CELL names an instance the netlist does not have, setInstance reports it (warning 195) and leaves instance_ null, and the cell's entries are skipped -- every handler checks instance_ except timingCheckSetupHold1, shared by SETUPHOLD and RECREM, which passed it to network_->cell() and segfaulted. Guard it as timingCheckPeriod and timingCheckWidth are guarded, including the incremental-only condition.
Seen on nextpnr's SDF for a Xilinx 7-series design, whose cell names contain '/' (read as a hierarchy divider, so the instance is not found).