A retrying transaction replays rendered frames: RetryTransaction and the [AutoDatabase] generator go

docs/rules/index.md

@@ -51,7 +51,6 @@ Unlike everything under [Usage](#usage), these describe code that does not do wh
 
 - [SER350](SER350) - language version too low for generated code
 - [SER351](SER351) - a `[Resp]` declaration the fragment generator cannot implement
-- [SER352](SER352) - generated database members that are not implemented and will throw
 
 ## When these rules stay quiet
 

eng/StackExchange.Redis.Build/AnalyzerReleases.Unshipped.md

@@ -18,4 +18,3 @@ SER308  | Usage    | Warning  | QueuedResultAnalyzer: calling the library's own
 SER309  | Usage    | Warning  | RespInterpolationAnalyzer: literal text in a RESP interpolated command is parsed and encoded on every call, where a fragment or resolved command is prepared once
 SER310  | Usage    | Info     | CancellationAnalyzer: a redis call that cannot honour the CancellationToken parameter its enclosing method accepts
 SER351  | Build    | Warning  | RespFragmentGenerator: a [Resp] declaration that cannot be implemented, which would otherwise be skipped silently
-SER352  | Build    | Warning  | AutoDatabaseGenerator: an [AutoDatabase(WarnIfIncomplete = true)] type still has generated members that only throw; Release builds only

eng/StackExchange.Redis.Build/Diagnostics.cs

@@ -383,32 +383,5 @@ internal static class Diagnostics
         description: "The RespFragment generator implements [Resp] partial properties of type RespFragment or RespCommand; a declaration it cannot match is skipped, which would otherwise appear only as a missing implementation part.",
         helpLinkUri: HelpLink("SER351"));
 
-    /// <summary>
-    /// An <c>[AutoDatabase(WarnIfIncomplete = true)]</c> type still has members that only throw.
-    /// </summary>
-    /// <remarks>
-    /// <para>
-    /// A transition tripwire, not a code-quality rule. A type being migrated to a new implementation one
-    /// command at a time has the rest generated as throwing stubs; that is fine while the work is in
-    /// progress and <b>not</b> fine in something that ships, and the difference is invisible at a glance
-    /// because the whole point of the generated half is that nobody writes or reads it.
-    /// </para>
-    /// <para>
-    /// Reported only for <c>Release</c> builds (detected by the absence of the <c>DEBUG</c> preprocessor
-    /// symbol) so the inner development loop stays quiet, and only where the attribute opts in - the other
-    /// <c>[AutoDatabase]</c> users generate members that genuinely work by forwarding, and counting those
-    /// as "not implemented" would be both wrong and deafening.
-    /// </para>
-    /// </remarks>
-    public static readonly DiagnosticDescriptor AutoDatabaseIncomplete = new(
-        id: "SER352",
-        title: "Generated database members are not implemented",
-        messageFormat: "{0} member(s) of '{1}' are not implemented and will throw at run time",
-        category: BuildCategory,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        isEnabledByDefault: true,
-        description: "A type generated by [AutoDatabase(WarnIfIncomplete = true)] still has members that only throw; it is mid-transition and should not ship in that state.",
-        helpLinkUri: HelpLink("SER352"));
-
     private static string HelpLink(string id) => string.Format(HelpLinkFormat, id);
 }

src/StackExchange.Redis/Availability/RespRetryExecutor.cs

@@ -54,8 +54,8 @@ internal RespRetryExecutor(RespExecutorBase inner, RetryPolicy policy, Func<Canc
     /// <summary>The policy in force; read by the tests, which assert how a policy was resolved.</summary>
     internal RetryPolicy Policy => _controller.Policy;
 
-    /// <summary>The controller, shared with <see cref="RetryTransaction"/> so a transaction created from a
-    /// retrying database applies exactly the policy the database does.</summary>
+    /// <summary>The controller, shared with <see cref="RespRetryTransactionExecutor"/> so a transaction
+    /// created from a retrying database applies exactly the policy the database does.</summary>
     internal RetryController Controller => _controller;
 
     /// <summary>The executor underneath, so a second <c>WithRetry</c> can refuse rather than nest.</summary>