Repository navigation
Update Phensley dependencies to 1.16 for current timezone and CLDR data - #42
Draft
tdiamantidis-sqsp wants to merge 2 commits into
Draft
tdiamantidis-sqsp wants to merge 2 commits into
tdiamantidis-sqsp wants to merge 2 commits into
Conversation
…phensley/messageformat 1.16.0 change) This is in line with ICU behavior: https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/MessageFormat.html#format(java.lang.Object%5B%5D,java.lang.StringBuffer,java.text.FieldPosition) and was previously a bug in @phensley/messageformat, now fixed in 1.16.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reasoning
Refresh stale timezone and locale data: the previous timezone dependency used tzdb 2025b, while the latest is 2026e; CLDR is now at 48.
Update the message fixture to reflect the upstream fix for missing placeholders.
Evidence
After: Dependencies resolve to 1.16.1; the fixture expects
{foo} {bar}to remain.yarn buildpasses;yarn test --runInBandpasses all 942 tests across 48 suites.Merge Danger
Door: two-way
Revert the dependency, lockfile, and fixture changes to roll back.
Blast Radius: internationalization
Timezone rules and locale formatting can change across templates. Consumers must satisfy the updated
@phensley/cldr-corepeer range; missing ICU placeholders now remain in rendered messages.