PNG encoder throws an exception on x64 #1228

Activity

1. hishamco

   added

   needs triage

   on Jun 13, 2020
2. antonfirsov commented on Jun 15, 2020

   

   antonfirsov

   on Jun 15, 2020

   Member

   More actions

   @hishamco to make it actionable for us, can you please:

   1. Fill the issue template, making sure you include:

   • The exact type of your CPU
   • .NET Core version
   • OS version

   2. Provide the PNG you are trying to resize. Note: based on stack trace, the issue is in the PNG encoder.
3. antonfirsov

   changed the title [-]Image resize throws an exception on x64[/-] [+]PNG encoder throws an exception on x64[/+] on Jun 15, 2020
4. ArieGato commented on Jun 15, 2020

   

   ArieGato

   on Jun 15, 2020

   More actions

   Steps to Reproduce

   fire the following request to OrchardCore: https://my.domain/media/myimage.png?width=100

   System Configuration

   • ImageSharp version:
     SixLabors.ImageSharp 1.0.0-rc0002

   • Other ImageSharp packages and versions:
     SixLabors.ImageSharp.Web 1.0.0-rc0003

   • Environment (Operating system, version and so on):

   Published the web site in devops

   - task: DotNetCoreCLI@2
     inputs:
       command: 'publish'
       publishWebProjects: false
       projects: '**/CmsWeb.csproj'
       arguments: '-o $(Build.ArtifactStagingDirectory) -r win-x64 --self-contained'
   

   windows server 64 bit.
   .net core 3.1.5

   It fails for all the png files I tested, but here's an example.
   

   👍React with 👍1Reacted by James Jackson-South

   ❤️React with ❤️1Reacted by Anton Firszov
5. JimBobSquarePants commented on Jun 15, 2020

   

   JimBobSquarePants

   on Jun 15, 2020

   Member

   More actions

   Throwing line is here.

   ImageSharp/src/ImageSharp/Formats/Png/Zlib/Adler32.cs

   Line 133 in 0890bca

   Vector128<short> mad1 = Ssse3.MultiplyAddAdjacent(bytes1, tap1);

   The fix should be simple. I'm checking for Sse3 not the correct supplementary Ssse3 support.

   Ssse3.MultiplyAddAdjacent.MultiplyAddAdjacent(Vector128<byte> left, Vector128<sbyte> right)
6. JimBobSquarePants

   added a commit that references this issue on Jun 15, 2020

   Update Adler32 to correctly filter intrinsics. Fix #1228

   This issue will close once commit 69cd2f3 is merged into the 'main' branch.

   69cd2f3
7. JimBobSquarePants

   added

   bug

   formats:png

   and removed

   needs triage

   on Jun 15, 2020
8. JimBobSquarePants

   added this to the 1.0.0 milestone on Jun 15, 2020
9. JimBobSquarePants

   self-assigned this

   on Jun 15, 2020
10. sebastienros commented on Jun 15, 2020

    

    sebastienros

    on Jun 15, 2020

    More actions

    Would this happen on any Windows machine or does it depend on the cpu ?
11. JimBobSquarePants commented on Jun 15, 2020

    

    JimBobSquarePants

    on Jun 15, 2020

    Member

    More actions

    @sebastienros depends on the CPU. Many (most) likely support Ssse3

    https://en.m.wikipedia.org/wiki/SSSE3
12. JimBobSquarePants

    closed this as completedin #1229on Jun 15, 2020