Repository navigation
Start PR checks on bot-created PRs - #8758
Closed
Suleimanlatrsh wants to merge 1 commit into
Closed
Suleimanlatrsh wants to merge 1 commit into
Suleimanlatrsh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Bot PRs from
maintenance-prsandgardener-backlog-prsget no CI. They are opened withGITHUB_TOKEN, and GitHub does not startpull_requestworkflows for events made with that token. For example, #8751 shows "No checks reported". Today the gardener has to close and reopen each PR to start the tests.WHAT is this pull request doing?
tests-pr.yml: adds aworkflow_dispatchtrigger. The graphql-codegen check now also runs on dispatch. Without that it would be skipped, and a skipped required check counts as passing.maintenance-prs.ymlandgardener-backlog-prs.yml: add astart-pr-checksjob that runs after the agent. If the run opened a PR, the job dispatchestests-pr.ymlon the PR branch. The resulting check runs attach to the PR's head commit, the same way/snapitworks since Restore /snapit using workflow dispatch #8721.actions: writeis only granted to the new job, not the agent's job. Otherwise the agent could dispatch other workflows such asrelease.yml.Type-diff, breaking change detection and the E2E jobs still skip on dispatch because they need
pull_requestcontext. None of them are required checks.How to manually test your changes?
workflow_dispatchonly works once the trigger is onmain, so this can't be fully tested before merge. What I checked:actionlintpasses on all three files.37247687073. It matched exactly the 4 PRs from that run ([Tests] Cover DoctorSuite filesystem assertions #8748 to [Refactor] Count deploy errors per extension with a Map #8751).After merge, run
maintenance-prsfrom the Actions tab. Each new PR should show the PR checks without a close and reopen.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add