Repository navigation
Align CSP check catalog severity to medium - #8752
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A patch changeset and regression coverage are missing.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns the CSP catalog severity with the agentic check.
Changes:
- Changes
MISSING_EMBEDDED_CSPfrom high to medium. - Keeps its score at
-10.
| File | Description |
|---|---|
packages/app/src/cli/services/app-security-engine/rules/catalog.ts |
Aligns CSP severity metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmerand
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
MISSING_EMBEDDED_CSPcatalog entry sayshigh, but the agentic check, which is the only thing that emits this finding, saysmedium. The scan artifact snapshots the catalog's severity, soshopify app security checkended up showing two different severities for the same check.WHAT is this pull request doing?
Changes the catalog severity to
mediumso it matches the check. Points stay the same (-10, which othermediumentries also use).How to manually test your changes?
shopify app security checkon an embedded app. TheMISSING_EMBEDDED_CSPcatalog entry in the scan artifact now reportsmedium.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add