镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix theme dev failures with large storefront headers - #8746

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/theme-dev-large-headers-8717
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/theme-dev-large-headers-8717

Conversation

@efegokdemir

Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #8717

The theme dev proxy inherits Node and Undici header-size defaults. Cookie-heavy storefronts can exceed those defaults and return 502s.

WHAT is this pull request doing?

  • Explicitly allow 128 KiB headers for storefront requests and the local theme dev server, including forwarded cookie headers.
  • Preserve Shopify proxy environment settings with an Undici EnvHttpProxyAgent and show network error codes on the storefront error page.
  • Add regression coverage for large upstream response headers, large local request headers, and error-code display, plus a theme patch changeset.

How to manually test your changes?

Run shopify theme dev for a storefront whose browser cookie jar produces more than 40 KiB of headers. Confirm storefront pages continue to render and localhost cookie forwarding does not return 502.

@efegokdemir
efegokdemir requested review from a team as code owners October 2, 2026 20:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: theme dev proxy 502s on cookie-heavy storefront responses (undici default 16 KiB maxHeaderSize)

1 participant