Allow --config with --client-id on app deploy and dev - #8735
Open
isaacroldan wants to merge 4 commits into
Open
isaacroldan wants to merge 4 commits into
isaacroldan wants to merge 4 commits into
Conversation
Deploy the configuration selected by --config to the app identified by --client-id, even if another TOML is linked to that client ID. This matches what already happens with `app config use <name>` followed by `app deploy --client-id <id>`. Requested by Isaac Roldan <isaac.roldan@shopify.com> Co-authored-by: Isaac Roldan <isaac.roldan@shopify.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
app deployandapp devreject--configwith--client-id, so users must first change the default configuration to use an existing TOML with another app.WHAT is this pull request doing?
Allow
app deploy,app dev, andapp dev cleanto use the selected TOML with the requested client ID. Keep an explicit client ID through startup, extension imports, and file-watcher reloads. When no client ID is specified, reloads continue to read it from the TOML.Add tests for flag validation and real TOML loading, including function manifests, target app settings, config edits, and unchanged source client IDs. Refresh the command manifest, README, and Shopify docs.
How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add