镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[stable] Add some bugfixes - #3991

Merged
gonzaloriestra merged 8 commits into
stable/3.61from
fix-pubsub-url-validation
Jun 6, 2024
Merged

gonzaloriestra merged 8 commits into
stable/3.61from
fix-pubsub-url-validation

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jun 6, 2024 •

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

@github-actions

github-actions Bot commented Jun 6, 2024 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟡 Statements 71.88% 7216/10039
🟡 Branches 68.96% 3537/5129
🟡 Functions 71.5% 1932/2702
🟡 Lines 73.13% 6792/9287

Test suite run success

1684 tests passing in 780 suites.

Report generated by 🧪jest coverage report action from ffdd867

@gonzaloriestra gonzaloriestra changed the title [stable] Fix validation for Pub/Sub URLs in webhook trigger [stable] Add some bugfixes Jun 6, 2024
@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -5,7 +5,7 @@ declare abstract class BaseCommand extends Command {
     static analyticsNameOverride(): string | undefined;
     static analyticsStopCommand(): string | undefined;
     catch(error: Error & {
-        skipOclifErrorHandling: boolean;
+        exitCode?: number | undefined;
     }): Promise<void>;
     protected init(): Promise<any>;
     protected showNpmFlagWarning(): void;
packages/cli-kit/dist/public/node/logs.d.ts
@@ -1,3 +1,3 @@
-export declare const getLogsDir: () => string;
+export declare const getLogsDir: string;
 export declare const createLogsDir: (path: string) => Promise<void>;
 export declare const writeLog: (path: string, logData: string) => Promise<void>;
\ No newline at end of file

@gonzaloriestra
gonzaloriestra merged commit b4806d0 into stable/3.61 Jun 6, 2024
@gonzaloriestra
gonzaloriestra deleted the fix-pubsub-url-validation branch June 6, 2024 16:11

This branch was previously deployed

2 inactive deployments
stable_3_61 — ffdd867c Deployed Jun 7, 2024 by shopify-shipit[bot]
experimental — ffdd867c Deployed Jun 7, 2024 by shopify-shipit[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants