Repository navigation
Refactor webhook trigger command to handle organization switches - #3727
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success1630 tests passing in 761 suites. Report generated by 🧪jest coverage report action from 7976091 |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.59.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.58.0";
\ No newline at end of file
|
gonzaloriestra
force-pushed
the
organization-switch
branch
from
April 16, 2024 14:49
4a9cf5b to
a023b03
Compare
gonzaloriestra
force-pushed
the
webhook-trigger-refactor
branch
from
April 16, 2024 14:50
ab02be8 to
2f1a78a
Compare
gonzaloriestra
commented
Apr 17, 2024
gonzaloriestra
commented
Apr 17, 2024
gonzaloriestra
commented
Apr 17, 2024
gonzaloriestra
commented
Apr 17, 2024
gonzaloriestra
marked this pull request as ready for review
April 17, 2024 07:32
This comment has been minimized.
This comment has been minimized.
shauns
approved these changes
Apr 19, 2024
isaacroldan
approved these changes
Apr 19, 2024
pacocastrotech
approved these changes
Apr 19, 2024
pacocastrotech
left a comment
Contributor
There was a problem hiding this comment.
Checked and tophatted. LGTM!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 19, 2024
gonzaloriestra
force-pushed
the
webhook-trigger-refactor
branch
from
April 19, 2024 15:28
9eceb75 to
f2dc1f4
Compare
gonzaloriestra
enabled auto-merge
April 19, 2024 15:28
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 19, 2024
gonzaloriestra
force-pushed
the
webhook-trigger-refactor
branch
from
April 22, 2024 08:20
f2dc1f4 to
7976091
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2024
4 of 6 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Continuation of #3713
WHAT is this pull request doing?
webhook trigger..env.client-id,path,config.How to test your changes?
p shopify webhook triggerwith and withoutUSE_SHOPIFY_DEVELOPERS_CLIENTPost-release steps
Update CLI documentation from the main branch:
/docs-shopify.dev/generatedto the shopify.dev repo in the folderdb/data/docs/templated_apis/shopify_cliMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.