Repository navigation
chart(feature): add extraVolumes, extraVolumeMounts and initContainers to router and distributor - #3253
Open
DrFaust92 wants to merge 4 commits into
Conversation
…s to router and distributor The hub already exposes extraVolumes/extraVolumeMounts and browser nodes expose initContainers, but the isolated router and distributor expose neither, so there is no way to add a volume or an init step to them. That blocks common setups such as loading a Java agent (e.g. the Prometheus JMX exporter) via SE_JAVA_OPTS for JVM heap/GC/thread metrics. Also adds initContainers to the hub for parity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com>
…ttps:https://github.com/DrFaust92/docker-selenium into chart-control-plane-extra-volumes-init-containers
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Adds
components.router.{extraVolumes,extraVolumeMounts,initContainers}andcomponents.distributor.{extraVolumes,extraVolumeMounts,initContainers}, rendered the same way as the existinghub.extraVolumes/hub.extraVolumeMounts(passed throughtpl). Also addshub.initContainers, so all three control-plane shapes have the same hooks. All defaults are[], so rendered output is unchanged unless the new values are set.CONFIGURATION.mdis regenerated with helm-docs.Motivation and Context
In isolated mode the router and distributor accept only env vars, so you can't add a file or an init step to them. The use case behind this is JVM observability: we hit a distributor stall under a large burst of sessions, and had no heap, GC or thread metrics to diagnose it. With these hooks an initContainer can drop a Java agent such as
jmx_prometheus_javaagentinto anemptyDir, andSE_JAVA_OPTS/JAVA_OPTScan load it with-javaagent:. The same hooks also cover custom truststores, extra jars forSE_EXTRA_LIBS, and log volumes.Types of changes
Checklist
test_extra_volumes_and_init_containers_in_router_and_distributorpasses. Locallytest_monitoring_grafana_dashboardsfails, but it fails identically on unmodifiedtrunk, so it's unrelated to this change.