Repository navigation
fix orchestrate plan: show kernel shapes and drop repeated what-if rows - #21
Open
Abhishek-B-R wants to merge 1 commit into
Open
Abhishek-B-R wants to merge 1 commit into
Abhishek-B-R wants to merge 1 commit into
Conversation
extract.py writes each kernel's shape under model_shape, but cmd_plan read a shape key that is never written, so the Shape column was always blank. The what-if loop also listed top-N twice whenever the plan had 5 or fewer kernels, because min(len, 10) repeated 1, 3 or 5.
Author
|
@jaberjaber23 friendly bump: this makes |
Author
|
@jaberjaber23 following up once more: the branch still merges cleanly with main, and it's a single commit so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orchestrate.py plannever shows the kernel shape. extract.py writes it undermodel_shape, but cmd_plan readsshape, which nothing writes, so the column is always empty.Same command also prints each what-if line twice when the plan has 5 or fewer kernels, since
min(len(kernels), 10)lands on 1, 3 or 5 again.Repro: build a plan with extract.generate_optimization_plan for 3 kernels and run cmd_plan on it.
Two line change in cmd_plan, still falls back to
shapefor hand written plans. Doesn't touch the time budget code that #13 changes.