Repository navigation
Added inbound sms SDR event - #2880
Merged
Merged
Conversation
jaimecasero
reviewed
Mar 19, 2018
| final SmsMessage record = builder.build(); | ||
| final SmsMessagesDao messages = storage.getSmsMessagesDao(); | ||
| messages.addSmsMessage(record); | ||
| getContext().system().eventStream().publish(record); |
Contributor
There was a problem hiding this comment.
i could not find any other occurence of eventStream usage. how is this supposed to be consumed? where is the subcriber regsitered?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
@jaimecasero are any comments left from your side? |
|
@agafox impl seems ok. do we need to add any test to cover this case? |
|
i was thinking maybe we can cover that RC is publishing on desired events in RC side as well. but as Oleg said he will cover it on sdr service side. this pr is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.