Repository navigation
Revert new rules on list(NULL) assignment - #6759
Merged
Merged
Conversation
|
Generated via commit b9436f4 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
Author
|
Failed tests are because I missed one line in R/data.table.R. I should have done the reversion more properly like so: git revert 1aa92bc4ab3206b5e9f8accdc5b205edbb76c73a
# resolve conflicts
git commit -a
# restore changes to tests
git checkout 1aa92bc4ab3206b5e9f8accdc5b205edbb76c73a -- inst/tests/tests.Rraw
# resolve conflicts ?
git commit -aI discovered the missing line by doing the above in a local branch and then checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6167 (retaining its tests). Closes #6740. Re-opens #5558.
cc @joshhwuu