Use *iB for power-of-2 bytes units consistently #7079

Activity

1. MichaelChirico commented on Jul 3, 2025

   

   MichaelChirico

   on Jul 3, 2025

   MemberAuthor

   More actions

   Two particularly problematic things:

   The use of buffMB as a parameter in fwrite():

   data.table/man/fwrite.Rd

   Line 17 in 4773ef9

   buffMB = 8L, nThread = getDTthreads(verbose),

   The use of mb as a parameter and output column name MB in tables():

   data.table/man/tables.Rd

   Line 12 in 4773ef9

   \item{mb}{ a function which accepts a \code{data.table} and returns its size in bytes. By default, \code{type_size} (same as \code{TRUE}) provides a fast lower bound by excluding the size of character strings in R's global cache (which may be shared) and excluding the size of list column items (which also may be shared). A column \code{"MB"} is included in the output unless \code{FALSE} or \code{NULL}. }

   I'm not sure it's worth a breaking change for renaming any of those, but something to consider. We can at least correctly describe whether they actually refer to MB or MiB (IINM it's always actually MiB).

   👍React with 👍1Reacted by aitap
2. MichaelChirico

   added

   breaking-changeissues whose solution would require breaking existing behaviorissues whose solution would require breaking existing behavior

   on Jul 6, 2025