Repository navigation
froll.Rraw could use test()'s options verbose #7013
Description
instead of using
options(datatable.verbose=TRUE)
test(...)
options(datatable.verbose=FALSE)we could use
test(..., options(datatable.verbose=TRUE))Filling out this issue to not forget.
As this is not a high priority, it is postponed till rolling functions related PRs are merged, to reduce work needed to resolve merge conflicts.
Activity
jangorecki commentedon May 23, 2025
I think we should not blindly replace all such instances as some extreme cases will bring an extra cost at no benefits really.
In case of having hundreds of verbose tests (I don't think we have them here) in a block we will just waste a lot of screen for readers of those tests in future.
Moreover package size will get unnecessarily bigger because of storing same string repeatedly hundreds of times.
MichaelChirico commentedon May 26, 2025
In such cases we should wrap the block of tests in
local(), to make them more hermetic.