镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Preserve vision-session history and add local entry point - #1

Merged
sergiopadure merged 2 commits into
v2-portfrom
integrator/rai2959-retain-history
Oct 10, 2026
Merged

sergiopadure merged 2 commits into
v2-portfrom
integrator/rai2959-retain-history

Conversation

@sergiopadure

Copy link
Copy Markdown

Summary

 vision request completes
-  remove the temporary session
+  preserve the session and its history

 vision request fails or times out
-  remove the temporary session
+  interrupt owned unfinished work with resume:false
+  keep the recursion guard until cleanup is confirmed

Adds the local-directory root entry point and includes it in the package file list. Late session creation or prompt admission cannot advance to another model request after abandonment.

Evidence

  • Before: cleanup called session.remove, deleting vision-session history.
  • After: 44 offline tests pass. Typecheck, build and root import pass. Independent review verifies the interrupt input against OpenCode v2.0.26's generated client.
  • Linux live acceptance: an existing text-only model returned the exact marker from a synthetic image. Both the outer session and internal vision session remained readable afterward.

Merge Danger

Door: two-way

Revert this branch and restore the previous package build. Do not delete session history as part of rollback.

Blast Radius: vision

Sessions whose pending requests never settle remain guarded for the process lifetime. Interrupts are bounded. Native runtime failure and timeout paths have offline coverage but were not deliberately exercised against a live model.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 07:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T07:36:02.746594Z bcc19b4 PR opened
🔒 Security Review ✅ Completed 2026-10-10T07:37:03.792560Z bcc19b4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sergiopadure

Copy link
Copy Markdown
Author

Independent review is complete on exact head bcc19b4. The finite native interrupt correction matches OpenCode v2.0.26. All44 offline tests, typecheck and root import pass. Linux installation and synthetic image-to-text acceptance passed, with both session histories preserved. No destructive session API call remains in the reviewed source/build.

Merge remains held at a tooling boundary: the current estate verification tool hardcodes origin/main, while this PR correctly targets v2-port and the default master contains legacy V1. The tool will not be redirected to the wrong branch or replaced by a new framework for this small change. A specifically approved exact-head native GitHub merge to v2-port can complete source delivery. No package publication or legacy branch update is involved.

This is a stated source-merge blocker, not failed code acceptance. The reviewed branch and existing base remain preserved. The installed runtime matches this head. Deployment rollback restores the previous local build and removes only the added root shim. Source rollback would revert this PR's eventual merge on v2-port. Live timeout/error paths were not deliberately induced against a model; their lifecycle coverage remains offline.

@sergiopadure
sergiopadure merged commit 7a63931 into v2-port Oct 10, 2026
@sergiopadure
sergiopadure deleted the integrator/rai2959-retain-history branch October 16, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants