Repository navigation
Fix up debugger attach handlers - #2130
Merged
Andy Jordan (andyleejordan) merged 1 commit intoJan 25, 2024
Merged
Conversation
Andy Jordan (andyleejordan)
force-pushed
the
andyleejordan/fixup-debug-configs
branch
from
January 16, 2024 23:39
cbb9e09 to
12adcc0
Compare
Andy Jordan (andyleejordan)
marked this pull request as ready for review
January 17, 2024 00:07
Andy Jordan (andyleejordan)
force-pushed
the
main
branch
from
January 18, 2024 01:30
a83a023 to
70ef45d
Compare
Andy Jordan (andyleejordan)
force-pushed
the
andyleejordan/fixup-debug-configs
branch
from
January 24, 2024 19:13
12adcc0 to
2968e35
Compare
First off, the error messages were never actually displayed to the user because the RpcErrorException constructor takes three arguments. Now the second argument is always (correctly but annoyingly) null. Secondly, we do not support attaching to PowerShell Editor Services. It sure looked like we did (because we had special logic for it) but once attached, nothing worked. So it was half-baked. Now we throw an error if the user is trying to do that. Thirdly, because of that half-baked implementation, the process ID field was typed as a string (to support "current" as a shortcut) but that caused a mess here and an error in the VS Code client. Now it's just always an integer. (Same for the runspace ID.) Fourthly, a big mess was cleaned up by refactoring using functions, who'd have thought? Fifth and finally, superfluous version checking around PowerShell <5.1 was removed (as those versions are no longer supported whatsoever).
Andy Jordan (andyleejordan)
force-pushed
the
andyleejordan/fixup-debug-configs
branch
from
January 24, 2024 19:17
2968e35 to
5632cad
Compare
Andy Jordan (andyleejordan)
enabled auto-merge
January 24, 2024 21:08
Dongbo Wang (daxian-dbw)
approved these changes
Jan 25, 2024
Andy Jordan (andyleejordan)
added this pull request to the merge queue
Jan 25, 2024
Andy Jordan (andyleejordan)
deleted the
andyleejordan/fixup-debug-configs
branch
January 25, 2024 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, the error messages were never actually displayed to the user because the
RpcErrorExceptionconstructor takes three arguments. Secondly, we do not support attaching to PowerShell Editor Services. It sure looked like we did (because we had special logic for it) but once attached, nothing worked. So it was half-baked. Now we throw an error if the user is trying to do that. Thirdly, because of that half-baked implementation, the process ID field was typed as a string (to support "current" as a shortcut)but that caused a mess here and an error in the VS Code client. Now it's just always an integer. (Same for the runspace ID.) Fourthly, a big mess was cleaned up by refactoring using functions, who'd have thought? Fifth and finally, superfluous version checking around PowerShell <5.1 was removed (as those versions are no longer supported whatsoever).