Repository navigation
Fix attach to process debugging - #1752
Merged
Andy Jordan (andyleejordan) merged 14 commits intoApr 18, 2022
Merged
Andy Jordan (andyleejordan) merged 14 commits into
Andy Jordan (andyleejordan) merged 14 commits into
Conversation
Fixes PowerShell#1736 - Add a new context frame for runspace entrance and REPL loops - Ensure runspace access is not attempted on a broken runspace - When a remote runspace hits a debugger stop, ensure that the origin pipeline thread does not run a REPL concurrently - Fix many race conditions
Patrick Meinecke (SeeminglyScience)
marked this pull request as ready for review
April 12, 2022 13:57
Patrick Meinecke (SeeminglyScience)
requested a review
from Andy Jordan (andyleejordan)
as a code owner
April 12, 2022 13:57
If multiple Write-Host's exist then this test will fail. FilterText contains the module qualified name when dupes are present.
If the testing machine has a pester template installed the collection will have an extra item.
| && (CurrentFrame.FrameType & PowerShellFrameType.Nested) is 0) | ||
| { | ||
| _shouldExit = false; | ||
| PopPowerShell(); |
There was a problem hiding this comment.
Ok, we'll need to walk through the logic here and above together, it hurt my head 🤕
Collaborator
Author
There was a problem hiding this comment.
It hurt my head to write it if it makes you feel any better 😁
For real though, a lot of what made PSES complicated before was controlling for scenarios like this. One runspace is pretty easy, multiple is a lot harder. It's also what made it prone to dead locks and slowness.
The difference this time though is I wrote it in a way where the extra complexity only really has an effect when it has to. So the normal everyday debugging loop should be completely unaffected but we still get reliable attach debugging. Thankfully Rob's work made it much easier to write in this way.
Member
|
Sorrrry for merge conflicts. |
Member
|
I'm excited to get this in! |
Patrick Meinecke (SeeminglyScience)
requested a review
from Andy Jordan (andyleejordan)
April 18, 2022 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1736
Keeping as draft for now as I have to fix probably a lot of merge conflictsWay less than I expected