Repository navigation
Run the weekly SIPNET integration test against SIPNET v2.2.0 too - #4191
Draft
madhavzanwar wants to merge 1 commit into
Draft
madhavzanwar wants to merge 1 commit into
madhavzanwar wants to merge 1 commit into
Conversation
sipnet.yml takes an optional sipnet-version input (default v1.3.0) and downloads either the v1 binary or the v2 tarball. ci-weekly.yml adds a job that uses v2.2.0. Refs PecanProject#3870
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3870. Following @dlebauer's suggestion to add SIPNET 2.2.0 to CI,
and @infotroph's earlier suggestion to keep the v1.3.0 run.
What
sipnet.yml: new optionalsipnet-versioninput, defaultv1.3.0, soPR CI behaves as before. The download step picks the right asset: v1.x
releases ship a bare binary, v2.x releases ship
sipnet-linux-x86_64-<version>.tar.gzcontainingsipnet.ci-weekly.yml: newsipnet-v2job running the integration test againstv2.2.0(R 4.5 only). It runs weekly only, not on PRs.Testing
binary (v2.2.0 reports
SIPNET version 2.2.0).the CI container), so I don't know yet whether it passes with v2.2.0. This
is a draft until the weekly workflow has run once on my fork
(workflow_dispatch). A failure there would be information about v2, not
necessarily a bug in this PR.