Repository navigation
Update LuaFileSystem to 1.9.0 preserving OpenXRay registration - #1
Closed
makarkotlov wants to merge 10 commits into
Closed
makarkotlov wants to merge 10 commits into
makarkotlov wants to merge 10 commits into
Conversation
Fixes warnings (probably) introduced with 64-bit. Mainly explicit typecasts to int to silence "possible loss of precision" warnings. These are lengths of filenames, so they're not going to exceed 4GB.
This was referenced Sep 25, 2026
Member
|
Superseded by OpenXRay/xrLuaFix@f30796b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream LuaFileSystem
v1_9_0(a186cca5833691e830ed255e38ace8ff6b870dbf) into the OpenXRay fork, retaining itsluaL_registerinitialization fix unchanged.The update includes compiler-warning fixes, explicit allocation casts for C++ compilation, and internal linkage for Windows helper functions. The OpenXRay registration path continues to target Lua 5.1/LuaJIT; no newer Lua API compatibility is claimed.
Validation on macOS ARM64: xrLuaFix and xrScriptEngine Debug/unity builds passed against the engine's unchanged LuaJIT pin. The upstream test suite passed using the lfs object from the engine-built xrLuaFix archive, plus checks for version 1.9.0, global/require module identity, directory lock contention and unlock. Windows execution was unavailable locally.