镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

MongoDB/*mongoose* deprecations #1516

Open
Open
MongoDB/*mongoose* deprecations#1516
Labels
CODESome other Code related issue and it should clearly describe what it is affecting in a comment.migrationUse this to indicate that it may apply to an existing or announced migration.

Description

@Martii
Martii
opened on Aug 26, 2018
(node:26124) DeprecationWarning: collection.count is deprecated, and will be removed in a future version. Use collection.countDocuments or collection.estimatedDocumentCount instead

We use .count in at least [one place] where this can be changed although upstream says it's still using the MongoDB v3.x driver... so that's confusing.

Refs:

With --trace-deprecation:

(node:7904) DeprecationWarning: collection.count is deprecated, and will be removed in a future version. Use collection.countDocuments or collection.estimatedDocumentCount instead
    at NativeCollection.(anonymous function) [as count] (~/OpenUserJS.org2/node_modules/mongoose/lib/drivers/node-mongodb-native/collection.js:146:28)
    at NodeCollection.count (~/OpenUserJS.org2/node_modules/mquery/lib/collection/node.js:50:19)
    at model.Query.Query._count (~/OpenUserJS.org2/node_modules/mongoose/lib/query.js:2081:20)
    at process.nextTick (~/OpenUserJS.org2/node_modules/kareem/index.js:369:33)
    at process._tickCallback (internal/process/next_tick.js:61:11)
(node:7904) DeprecationWarning: Cursor.each is deprecated. Use Cursor.forEach instead.
    at ~/OpenUserJS.org2/libs/modifySessions.js:293:19
    at handleCallback (~/OpenUserJS.org2/node_modules/mongodb/lib/utils.js:128:55)
    at Collection.<anonymous> (~/OpenUserJS.org2/node_modules/mongodb/lib/collection.js:432:45)
    at Collection.deprecated [as find] (~/OpenUserJS.org2/node_modules/mongodb/lib/utils.js:661:17)
    at exports.findSessionData (~/OpenUserJS.org2/libs/modifySessions.js:279:15)
    at Timeout.ttlSanity [as _onTimeout] (~/OpenUserJS.org2/app.js:552:3)
    at ontimeout (timers.js:436:11)
    at tryOnTimeout (timers.js:300:5)
    at listOnTimeout (timers.js:263:5)
    at Timer.processTimers (timers.js:223:10)

... doing this kills session management... so delay.... FIXED (this one code fence only)

(node:10349) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.

Activity

  1. Martii
    added
    migrationUse this to indicate that it may apply to an existing or announced migration.
    CODESome other Code related issue and it should clearly describe what it is affecting in a comment.
    on Aug 26, 2018
  2. Martii
    changed the title [-]`collection.count` is deprecated[/-] [+]MongoDB/*mongoose* deprecations[/+] on Aug 26, 2018

  3. Martii commented on Aug 26, 2018

    @Martii
    Martii
    on Aug 26, 2018
    MemberAuthor

    These show up in local pro (different MongoDB version... already emailed sizzle about this incongruity):

    (node:26443) DeprecationWarning: collection.find option [fields] is deprecated and will be removed in a later version.
(node:26443) DeprecationWarning: collection.find option [fields] is deprecated and will be removed in a later version.
Connected to MongoDB v3.0.15
GitHub client authenticated
(node:26443) DeprecationWarning: collection.update is deprecated. Use updateOne, updateMany, or bulkWrite instead.
(node:26443) DeprecationWarning: collection.count is deprecated, and will be removed in a future version. Use collection.countDocuments or collection.estimatedDocumentCount instead
(node:26443) DeprecationWarning: Cursor.each is deprecated. Use Cursor.forEach instead.

    And some more...

    (node:26443) DeprecationWarning: collection.remove is deprecated. Use deleteOne, deleteMany, or bulkWrite instead.
(node:26443) DeprecationWarning: collection.update is deprecated. Use updateOne, updateMany, or bulkWrite instead.
(node:26443) DeprecationWarning: collection.remove is deprecated. Use deleteOne, deleteMany, or bulkWrite instead.

    Ref:

    (node:32265) DeprecationWarning: collection.findAndModify is deprecated. Use findOneAndUpdate, findOneAndReplace or findOneAndDelete instead.

    ... string findAndModify not found in our project but other deps have it.

    ...

    (node:12406) DeprecationWarning: Mongoose: `findOneAndUpdate()` and `findOneAndDelete()` without the `useFindAndModify` option set to false are deprecated. See: https://mongoosejs.com/docs/deprecations.html#-findandmodify-

    Ref: Automattic/mongoose#7865

  4. Martii
    added 2 commits that reference this issue on Oct 13, 2018

    Some dep updates

    c7b2443

    Some dep updates (#1528)

    c5cb49c
  5. Martii
    added 2 commits that reference this issue on Dec 19, 2018

    Use URL WHATWG for *mongoose*

    22a4ca3

    Use URL WHATWG for *mongoose* (#1554)

    a32e8bc
  6. Martii
    self-assigned this
    on Jan 16, 2019
  7. Martii
    added 2 commits that reference this issue on Jan 16, 2019

    Squash a deprecation in our Code base

    4d2d91f

    Squash a deprecation in our Code base (#1573)

    4250e25
  8. Martii
    removed their assignment
    on Jan 16, 2019
  9. Martii
    self-assigned this
    on May 29, 2019
  10. Martii
    added 2 commits that reference this issue on May 29, 2019

    Some dep updates

    8a4ce15

    Some dep updates (#1611)

    a55aa7b
  11. Martii
    removed their assignment
    on May 29, 2019
  12. Martii
    added 4 commits that reference this issue on Jun 4, 2019

    Some dep updates

    307cd40

    Some dep updates (#1617)

    78651a6

    Resquash for pro a mongoDB/*mongoose* deprecation

    93d729e

    Resquash for pro a mongoDB/*mongoose* deprecation (#1619)

    d4fa972
  13. Martii
    added 2 commits that reference this issue on Jun 28, 2019

    Rollback back-end *node* engine support to LTS

    df627ea

    Rollback back-end *node* engine support to LTS (#1628)

    2df9157

  14. Martii commented on Jan 7, 2020

    @Martii
    Martii
    on Jan 7, 2020
    MemberAuthor

    During a dep update test cycle...

    (node:9303) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'createCollection' of undefined
    at NativeConnection.createCollection (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/connection.js:356:11)
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/connection.js:451:12
    at Object.promiseOrCallback (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/utils.js:261:12)
    at NativeConnection.createCollection (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/connection.js:445:18)
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/model.js:1299:13
    at Object.promiseOrCallback (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/utils.js:261:12)
    at Function.createCollection (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/model.js:1296:16)
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/model.js:1340:10
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/utils.js:283:5
    at new Promise (<anonymous>)
    at Object.promiseOrCallback (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/utils.js:282:10)
    at Function.syncIndexes (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/mongoose/lib/model.js:1337:16)
    at Object.<anonymous> (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/models/script.js:86:8)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
(node:9303) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:9303) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

    ... as far as I know we don't use promises but deps may internally.

    Squashed during testing:

    (node:8993) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.
    (node:9088) DeprecationWarning: The option `reconnectTries` is incompatible with the unified topology, please read more by visiting http://bit.ly/2D8WfT6
(node:9088) DeprecationWarning: The option `reconnectInterval` is incompatible with the unified topology, please read more by visiting http://bit.ly/2D8WfT6
  15. Martii
    added 2 commits that reference this issue on Jan 24, 2020

    Some dep updates and a downgrade

    6b29b87

    Some dep updates and a downgrade (#1703)

    1261d16
  16. Martii
    added 2 commits that reference this issue on Feb 5, 2020

    Some dep updates

    c22b236

    Some dep updates (#1706)

    4badd2e
  17. Martii
    added 2 commits that reference this issue on Sep 6, 2020

    Add `syncIndexes` to all models JIC

    01767d3

    Add `syncIndexes` to all models JIC (#1750)

    51becf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CODESome other Code related issue and it should clearly describe what it is affecting in a comment.migrationUse this to indicate that it may apply to an existing or announced migration.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions