[rtp_relay] keep the all-branches session across a failed branch - #4292
Open
killdashnine wants to merge 1 commit into
Open
killdashnine wants to merge 1 commit into
killdashnine wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4293. Follow-up to #4277, the other half of #4269.
rtp_relay_engage() from the request route should cover any further branches, but TMCB_ON_FAILURE deletes and frees that session. A branch created in the failure route (uac_auth() retry, failover) then goes out with the original SDP and the call is not relayed.
On ON_FAILURE this now releases the media of the failed attempt, drops the callee tag learned from it and keeps the session, so the next branch offers again. Per-branch sessions are untouched.
Tested on master and 3.6.9 with SIPp and rtpengine: 401 retry, 401 then 407, 503 failover, cancel during the retry, hold from either side, a challenged re-INVITE, UDP and TLS. Unpatched, rtpengine only sees offer, delete. shm stays flat over 1800 calls.