Repository navigation
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
|
Tagging this This PR deletes JS/CSS that was committed straight into Replacing these with Swing removes all of them from the IP review list. |
There was a problem hiding this comment.
MirthTagField.java:383: Tags that scroll off the left edge can’t be reached again. The tag row never shows a horizontal scrollbar, and the only scrolling code moves the text box into view. Once the tags are wider than the field, the first ones disappear past the left edge. Mouse-wheel scrolling doesn’t work without a visible scrollbar, and the old Home/arrow-key navigation is gone. The channel editor has no clear button, so removing the first tag means backspacing through every tag after it. It happens with roughly 8–10 long tag names. The Dashboard and Channels filter fields (max 500px wide) can hit it too. Old field overflowed too, but had keyboard navigation enabled.
Otherwise LGTM.
Reduces the JavaFX based WebView + JQuery + Swing tags control to only use swing. I think the prior webview design was to "test the waters" for using WebView and JFX, not as an actual requirement.
Performance impact is good. Drops idle CPU usage from ~2% to ~0.2%, drops memory usage by ~100 MB. Improves MacOS "power score" for the application by 88% - so there should be some benefit to battery life.
Also includes a drive-by fix for a bug where tag colors would oscillate on refresh if you had a channel and tag named the same thing.
Not a direct fix, but would close #434