Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Linux builds target x86_64, as reflected by the
*_x64build configurations, but their release archive names (REDRIVER2_Release.tar.gzandREDRIVER2_Release_dev.tar.gz) don't identify either Linux or the architecture. Windows archive names identify their target asWin32.I ran into this while adding REDRIVER2 to TarLink, my Linux manager for applications distributed as portable archives. TarLink uses release asset names to identify target platforms, so the current Linux names are ambiguous to it. I'm proposing the explicit name to make the target clear to TarLink and other downstream consumers, rather than adding a special case to my project.
What changes
Rename the Linux archives produced by
.appveyor/AfterBuild.shto includeLinux_x86_64, for example:REDRIVER2_Release.tar.gz→REDRIVER2_Linux_x86_64_Release.tar.gzREDRIVER2_Release_dev.tar.gz→REDRIVER2_Linux_x86_64_Release_dev.tar.gzThis is a packaging-name change only. It does not alter the build or existing release assets. The AppVeyor artifact glob still matches the
.tar.gzfiles.Verification
bash -n .appveyor/AfterBuild.shgit diff --checkAn AppVeyor build will provide the end-to-end check of the produced artifact names. If this naming change doesn't fit the project's release conventions, please feel free to close the PR.