Repository navigation
fix: select onboarding workspaces and expand macOS window drag regions - #753
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing onboarding after creating or cloning a workspace currently opens General (or the previous workspace). On macOS, the session title's full block also excludes empty toolbar space from native dragging, and the preload caption leaves most of the sidebar's top edge uncovered.
This PR:
Commits:
dc8ddf288— onboarding workspace selection and retry handling.e8357b416— macOS drag regions and desktop regression coverage.Validation
All local checks below passed on Windows using Node 22 and the repository's pinned pnpm:
pnpm --dir ui test: 334 files, 3,163 tests passed; 13 skipped.pnpm --filter pilotdeck-desktop test: 328 passed; 9 platform-dependent skips.pnpm --dir ui typecheck.pnpm --dir ui buildandnode scripts/check-ui-build-graph.mjs.pnpm --filter pilotdeck-desktop compile.pnpm --dir ui exec playwright test -c e2e/streaming-scroll.config.mjs onboarding-workspace.spec.mjs desktop-drag-regions.spec.mjs chat-navigation.spec.mjs settings-consistency.spec.mjswithPILOTDECK_TEST_BROWSER_CHANNEL=chrome: 16 passed.node ui/e2e/desktop-chrome.smoke.mjswith the compiled desktop and an isolated fixture Vite server: passed in native Windows Electron.git diff --checkand staged-diff inspection.The new creation and caption regressions were also run against the original
origin/mainimplementation: they failed for the reported behavior (route stayed at/p/general; caption stayed 100px wide). The fixed implementation passes. Fixtures use synthetic APIs, workspaces and isolated browser/Electron profiles; no provider calls are made.Platform limit
The macOS layout test uses the production preload and styles in Chromium with a synthetic macOS bridge. Actual macOS native window movement, traffic-light behavior and packaging were not executed on this Windows host. The macOS branch of desktop chrome acceptance now checks caption coverage at ten sidebar widths and preserves native double-click renaming; it still needs execution on macOS.