镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: select onboarding workspaces and expand macOS window drag regions - #753

Merged
xhd0728 merged 2 commits into
mainfrom
codex/fix-onboarding-workspace-macos-drag
Nov 11, 2026
Merged

xhd0728 merged 2 commits into
mainfrom
codex/fix-onboarding-workspace-macos-drag

Conversation

@xhd0728

@xhd0728 xhd0728 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Completing onboarding after creating or cloning a workspace currently opens General (or the previous workspace). On macOS, the session title's full block also excludes empty toolbar space from native dragging, and the preload caption leaves most of the sidebar's top edge uncovered.

This PR:

  • Navigates to the returned project's encoded route before refreshing the onboarding/auth gate. Successful creation results are retained for completion retries, so retrying selects the same workspace without creating it again.
  • Extends the macOS caption across the sidebar's top edge and limits the session title's no-drag area to its rendered text. Toolbar controls, double-click renaming, long-title truncation, collapsed sidebars and fullscreen behavior remain covered.
  • Adds both browser regressions to the existing CI browser suite and extends native desktop chrome acceptance.

Commits:

  • dc8ddf288 — onboarding workspace selection and retry handling.
  • e8357b416 — macOS drag regions and desktop regression coverage.

Validation

All local checks below passed on Windows using Node 22 and the repository's pinned pnpm:

  • pnpm --dir ui test: 334 files, 3,163 tests passed; 13 skipped.
  • pnpm --filter pilotdeck-desktop test: 328 passed; 9 platform-dependent skips.
  • pnpm --dir ui typecheck.
  • pnpm --dir ui build and node scripts/check-ui-build-graph.mjs.
  • pnpm --filter pilotdeck-desktop compile.
  • pnpm --dir ui exec playwright test -c e2e/streaming-scroll.config.mjs onboarding-workspace.spec.mjs desktop-drag-regions.spec.mjs chat-navigation.spec.mjs settings-consistency.spec.mjs with PILOTDECK_TEST_BROWSER_CHANNEL=chrome: 16 passed.
  • node ui/e2e/desktop-chrome.smoke.mjs with the compiled desktop and an isolated fixture Vite server: passed in native Windows Electron.
  • Focused onboarding/workspace, auth, project creation, desktop-command and header tests passed, including failed-creation retries and cached clone results.
  • git diff --check and staged-diff inspection.

The new creation and caption regressions were also run against the original origin/main implementation: they failed for the reported behavior (route stayed at /p/general; caption stayed 100px wide). The fixed implementation passes. Fixtures use synthetic APIs, workspaces and isolated browser/Electron profiles; no provider calls are made.

Platform limit

The macOS layout test uses the production preload and styles in Chromium with a synthetic macOS bridge. Actual macOS native window movement, traffic-light behavior and packaging were not executed on this Windows host. The macOS branch of desktop chrome acceptance now checks caption coverage at ten sidebar widths and preserves native double-click renaming; it still needs execution on macOS.

@xhd0728
xhd0728 merged commit 4764771 into main Nov 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant