[fadi-george]

Description

One Line Summary

Rename the Android demo to com.onesignal.sdkdemo and turn on Firebase Installation ID registration for E2E builds.

Details

Motivation

E2E should cover Firebase Installation ID registration. That needs firebase-messaging 25.1.2+, the manifest flag, and a google-services.json whose client matches the app package. Same approach as OneSignal/OneSignal-Android-SDK#2836 and OneSignal/OneSignal-Capacitor-SDK#81.

Scope

• Android package renamed to com.onesignal.sdkdemo in demo and demo-no-location. iOS stays com.onesignal.example. FID/E2E wiring is demo only.
• firebase-messaging 25.1.3 (OneSignal alone resolves 24.x).
• firebase_messaging_installation_id_enabled comes from -PFIREBASE_INSTALLATION_ID_ENABLED and defaults to false. The build fails if it's on without google-services.json. The Google Services plugin is applied only when the file exists.
• google-services.json is gitignored. The Android E2E job writes it from APPIUM_GOOGLE_SERVICES_JSON with sdk-shared setup-google-services, so an empty secret fails with that action's error. iOS doesn't touch it.
• E2E builds with the flag on and passes bundle-id: com.onesignal.sdkdemo to the Android Appium job.
• The default app ID is removed. metro.config.js fails the bundle when ONESIGNAL_APP_ID is unset in both process.env and .env, which covers react-native start and release bundling on both platforms.

Testing

Manual testing

• assembleRelease -PciSingleAbi -PFIREBASE_INSTALLATION_ID_ENABLED=true with a google-services.json builds. The APK has package com.onesignal.sdkdemo, the flag is true, and firebase-messaging resolves to 25.1.3.
• Without the file or flag, the build succeeds. With the flag but no file, it fails with a clear error.
• Without ONESIGNAL_APP_ID, loading metro.config.js throws. Setting it via process.env works.
• vp run lint passes.
• iOS build and E2E not run yet. E2E runs on rel/** or manual dispatch, and needs APPIUM_GOOGLE_SERVICES_JSON to have a com.onesignal.sdkdemo client.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code