Repository navigation
[17.0][FIX] spreadsheet_oca: Fix bug where sort order in pivot causes crash - #69
Merged
Merged
Conversation
Member
|
Thanks for the quick reply and fix. Please include the name of the module in the commit message according guidelines (https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message), but the fix is correct according the functional review. |
Fix bug where sort order in pivot causes crash due to changed function name getGroupByDisplayLabel to getMeasureDisplayName.
pedrobaeza
approved these changes
Sep 10, 2025
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
I have pushed the fix with proper commit message, so let's fast-track it to fix the problem. Thanks for the quick reaction:
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 9a416b9. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where sort order in pivot causes crash due to changed function name getGroupByDisplayLabel to getMeasureDisplayName in V17