Repository navigation
libvmaf: support clang-cl builds - #1708
Open
StormBytePP wants to merge 1 commit into
Open
StormBytePP wants to merge 1 commit into
StormBytePP wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the merge of #1477, which made MSVC builds a first-class citizen, this change complements Windows compilation by adding support for
clang-cl.Meson identifies
clang-clseparately frommsvc, even though it uses the Windows SDK and MSVC-compatible CRT. This change therefore:_USE_MATH_DEFINESforclang-clso Windows math constants such asM_PIare available._CRT_SECURE_NO_WARNINGSto avoid CRT deprecation warnings for functions such asstrncpyandstrcpy.clang-clfrom compiler flags that are not appropriate for this toolchain.