Repository navigation
Conversation
…values Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-integer value for --threads, --subsample or --cpumask made the vmaf tool abort in error() with
Assertion failed: (long_opts[n].name)instead of printing usage.These cases passed 't', 's' and 'c' to parse_unsigned(), but the long options are registered with ARG_THREADS, ARG_SUBSAMPLE and ARG_CPUMASK, so error() could not find the option in long_opts. Pass the ARG_* values, as --gpumask and --frame_cnt already do.
After the change:
Testing: added test_invalid_unsigned_option_prints_usage to test_cli_parse. It runs cli_parse() in a child process, since usage() exits, and checks for exit status 1. It fails on master (the child aborts) and passes with the fix. It is skipped on Windows, where fork() is not available.
ninja -C libvmaf/build testpasses (28/28).Fixes #1694