[NeilMazumdar]

Problem

An umbrella repository can show submodule pointers, but T3 cannot select a child repository to review its files. The Diff pane now has a searchable repository picker, with the repository name, branch and relative path. The umbrella remains the default and keeps native Git pointer diffs.

Change

Select an initialized submodule, including a nested one, to review its Changes, Uncommitted files, commits and comparison branches. Switching repositories resets the comparison branch to Automatic. Review comments retain workspace-relative file paths. Turn diffs and Git write actions remain tied to the thread's repository.

DiffPanel / ReviewSheet
  review.getRepositories(workspace cwd)
    ReviewService workspace guard
      GitVcsDriver.getReviewRepositories
        bounded discovery of initialized submodules
  select repository
    review.getDiffPreview(selected cwd)
    commit lists, refs and full-file expansion use the same cwd

Web and desktop share the picker. Native mobile has a repository menu. The web toolbar wraps in narrow panels. The parent entry uses the project title, and parent reviews preserve subdirectory and symlink workspace paths. Discovery resolves paths before entering child repositories, excludes uninitialized modules and paths outside the workspace, and runs separately from routine diff and status refreshes. Opening the picker or pressing Refresh rediscovers repositories.

This follows the separate-repository model in VS Code and Zed.

Phone walkthrough

A 70-second portrait recording at a 390 x 585 CSS-pixel phone viewport. It starts on the base build, where the parent diff has only submodule pointer rows. On the fork head it uses the picker to review auth, ui, catalog and the nested schema, then returns to the parent.

pr1-repository-picker-portrait.mp4

Scope and approval

The upstream proposal is in Ideas discussion #32784. It requests explicit maintainer approval for the repository-picker direction and review-only scope. This fork PR remains available for inspection while that approval is pending; no upstream PR has been opened for this implementation.

Verification

vp run check:changed passes formatting, lint, knip, GraphQL checks, affected-package typechecks, React Compiler checks, 412 changed-file tests and 17 cross-file checks. Regression coverage includes initialized and nested submodules, uninitialized modules, hostile manifest paths and symlinks, repository-scoped previews and commits, comment paths, selection resets and parent commit links.

Chrome MCP confirms umbrella pointer diffs, auth file contents, staged changes, the UI module's untracked file and nested detached-HEAD selection. The narrow web layout was checked at 390 CSS pixels. Native mobile changes are typechecked but have not been run in an iOS or Android app. An independent review of 6f331a0 found no P0 to P2 issues. The showcase comment has before and after stills from local builds of b90e554 and 6f331a0, the portrait walkthrough and a 59-second landscape walkthrough. Both videos play and seek in a signed-out, phone-width Chrome tab.

Models and harnesses: Opus 5.5 via Claude Code and Sol 6.1 via Codex, both through T3 Code. Sol implemented and validated the change; Opus independently reviewed it and captured the screenshots and recording.

[NeilMazumdar]

Contributing models and harnesses: Opus 5.5 via Claude Code and Sol 6.1 via Codex, both through T3 Code. Sol implemented the change and ran validation. Opus independently reviewed it and captured the before-and-after screenshots and recording.

The upstream direction and scope are proposed in Ideas discussion #32784, which links this fork PR and includes screenshots and video. Maintainer approval is pending.

[NeilMazumdar]

Showcase

Recorded on a local build of 6f331a0, with each before on a local build of its merge-base b90e554. The workspace is a synthetic umbrella with three submodules, one of which has its own nested submodule. Desktop shots are 1920 x 1080 in the light theme.

Phone walkthrough, portrait (70 s)

Recorded in Chrome at a 390 x 585 CSS-pixel viewport with mobile and touch emulation, for a phone held upright. Captions sit above the app, clear of the player's controls.

1. Before: the base build's Diff header has no repository picker. Submodules are pointer rows beside README.md and src/app.ts.
2. After: the same parent diff, with the repository picker in the header.
3. Open the picker: five repositories with their paths.
4. Pick auth and its staged src/policy.ts. Tap the title to open packages/auth/src/policy.ts, then close it.
5. Pick ui (theme.ts changed, tokens.ts untracked), catalog (config.ts and its vendor/schema pointer) and the nested schema on a detached HEAD.
6. Return to Atlas workspace.

pr1-repository-picker-portrait.mp4

Umbrella Changes view

Before, the umbrella lists its submodules as pointer rows and has no way to review a child repository.

After, the same pointer rows remain and the header gains a repository picker.

Reviewing a child repository

The picker lists each initialized repository with its branch and path. schema is nested inside catalog.

Clicking the title of auth's staged src/policy.ts opens packages/auth/src/policy.ts with the child's contents.

ui shows its untracked src/tokens.ts as an added file.

schema is a nested checkout on a detached HEAD, compared with Automatic.

At 390 CSS pixels the picker, refs and toolbar wrap onto separate rows.

Landscape walkthrough (59 s)

1. Before: the umbrella shows pointer rows only.
2. After: open the picker, search for auth and select it.
3. Expand src/policy.ts, then click its title to open the child's file.
4. Select ui, catalog and schema in turn.
5. Return to Atlas workspace and its own files.

pr1-repository-picker-showcase.mp4

Not shown: native iOS and Android, the Electron app, remote and relay connections, review comments and commit lists inside a child repository, the Latest turn view with a child selected, and the 256-repository discovery limit. Discovery bounds, hostile manifest paths and path guards are covered by tests.

[NeilMazumdar]

Continued upstream as pingdotgg#34105, from the same branch rebased onto current main. The pre-rebase head 6f331a0 is kept as the tag pre-upstream-rebase-6f331a02.