Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing supported deployment aliases silently produces zero-cost estimates and contradicts existing test expectations.
1 open finding
What changed in this PR
Updates COMPASS model pricing and extraction inputs, with a small collection-manifest ordering change.
Changes:
- Adds model pricing entries and removes deployment aliases.
- Exposes
save_search_engine_resultsin extraction inputs. - Moves
failed_targetswithin the manifest without changing its value.
| File | Description |
|---|---|
| compass/utilities/costs.py | Updates the model pricing registry. |
| compass/pipeline/data_classes.py | Documents and forwards the search-results persistence option. |
| compass/pipeline/collection/persistence.py | Reorders the manifest’s failed_targets field. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 81 81
Lines 8429 8429
Branches 909 909
=======================================
Hits 6031 6031
Misses 2225 2225
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor updates around costs and extraction inputs