镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Optimize contiguous CUDA tensor copies with cudaMemcpyAsync - #1279

Merged
cliffburdick merged 3 commits into
mainfrom
feature/copy-cuda-memcpy-async
Oct 29, 2026
Merged

cliffburdick merged 3 commits into
mainfrom
feature/copy-cuda-memcpy-async

Conversation

@cliffburdick

Copy link
Copy Markdown
Collaborator

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues remain.

Summary

This PR keeps CUDA byte copies limited to dense tensors and adds copy documentation and tests.

  • Sparse tensor copies stay on assignment instead of byte copying.

The earlier, unnumbered overlap finding is fixed: copy uses assignment, which checks for unsafe overlap before calling cudaMemcpyAsync.

Reviews (3) · Last reviewed commit: "Fix copy tests with narrowing conversion..." · Reviewed by Greptile

Comment thread include/matx/transforms/copy.h Outdated
Comment thread include/matx/transforms/copy.h Outdated
@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

1 similar comment
@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

2 similar comments
@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

@cliffburdick

Copy link
Copy Markdown
Collaborator Author

/build

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 93.704% — feature/copy-cuda-memcpy-async into main. No base build found for main.

@cliffburdick
cliffburdick merged commit c9c8b17 into main Oct 29, 2026
2 checks passed
@cliffburdick
cliffburdick deleted the feature/copy-cuda-memcpy-async branch October 29, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants