镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Use the same table number in the source id and the saved files - #444

Open
SashaMIT wants to merge 1 commit into
NVIDIA:mainfrom
SashaMIT:fix/pdf-table-source-number
Open

SashaMIT wants to merge 1 commit into
NVIDIA:mainfrom
SashaMIT:fix/pdf-table-source-number

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Oct 1, 2026 •

Copy link
Copy Markdown

parse_all_tables writes the spreadsheet and the image as table{ctr}, then increments ctr, then stores table{ctr} in the document source. The first table is saved as table1 and reported as table2. The second is saved as table2 and reported as table3.

The same increment sits in both community copies of the parser. The source id is now taken before the counter moves, so it matches the files just written.

The new test stubs the PDF and model imports and checks both copies. On tip the first source is report-page0-table2 while the file is table1-page0.xlsx. After the change both sources are table1 and table2.

The source id was incremented before it was written, so the first table was saved as table1 and reported as table2.

Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant