Conversation
The source id was incremented before it was written, so the first table was saved as table1 and reported as table2. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_all_tableswrites the spreadsheet and the image astable{ctr}, then incrementsctr, then storestable{ctr}in the document source. The first table is saved astable1and reported astable2. The second is saved astable2and reported astable3.The same increment sits in both community copies of the parser. The source id is now taken before the counter moves, so it matches the files just written.
The new test stubs the PDF and model imports and checks both copies. On tip the first source is
report-page0-table2while the file istable1-page0.xlsx. After the change both sources aretable1andtable2.