Repository navigation
getSourceFilePathInNewDir broken by recent commits #9768
Description
Activity
- added this to the milestone
on Jul 17, 2016 I don't quite understand. The
sourceFilePathis always an absolute path returned bygetNormalizedAbsolutePath, andgetCanonicalFileNameonly changes casing, so why does the cannonical source file path ofC:/Users/Nicholas/example/b/b.tsbecomeb.ts?getCanonicalFileNamedoes more than change the case; it returns a relative path. And ifC:/Users/Nicholas/example/bis the current directory,b.tsis the cannonical path. The examples I gave were from console outputs I placed in the source - with some upper directory levels removed.I think I see the problem.
getCanonicalFileNameis implemented in the host, so it'stsify's implementation that's being called. It's not calling the TypeScript implementation ofgetCanonicalFileName- which, as you've said, just changes the case.Thanks. I guess I have something to fix in
tsify.- locked and limited conversation to collaborators
on Jun 19, 2018
TypeScript Version: 2.0.0-beta
Zhengbo Li (@zhengbli) The following commit appears to have broken the
getSourceFilePathInNewDirimplementation in certain circumstances:Use getCanonicalFileName
The use of
getCanonicalFileNamebreaks the implementation if the common directory is a parent of the current directory.For example, with these files:
The common directory is
C:/Users/Nicholas/example.If the current directory is
C:/Users/Nicholas/example/b, for thea.tssource file:So
isSourceFileInCommonSourceDirectorywill betrue.However, for the
b.tssource file:So
isSourceFileInCommonSourceDirectorywill befalse- which will result in the absolute path to the source file -C:/Users/Nicholas/example/b/b.ts- being returned.Specifically, this change to the implementation breaks my tsify-based builds.