You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(release): preserve ACP session adoption state - #14
Carry the ACP session-adoption repair after the existing personal patches: use SubscriptionRef.set for observable config state.
Repair an Antigravity stop regression test that used the removed Crypto service; use SecureRandom as neighboring tests do.
Validation
Reproduced the adapter failure on generated snapshot 7a98834 before the fix.
With both fixes, all 19 non-browser carried-fix test commands passed locally: 882 test executions passed, with 205 filtered by the workflow's existing selectors. This includes the 132-test ACP adapter suite. Server, provider-acp, client-runtime and mobile typechecks passed; git diff --check passed.
The browser regression could not run locally: pinned Playwright Chromium download failed and system Chromium could not start in the environment, even on a second attempt. The web typecheck could not initialize its sandbox supervisor. Neither is represented as a pass. Hosted full release validation remains required before publication.
The fix list gains entries for updating observable ACP config state when adopting a session and using the current secure random service in the Antigravity stop test.
The release-fix entries follow the existing processing contract and no merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary ACP session-adoption state fix. It uses an appropriate conventional commit format.
Description check
The description explains the two fixes, validation results, related issue, and known test limitations. It does not use the template headings or provide explicit scope and approval details, but the req…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the two fixes, validation results, related issue, and known test limitations. It does not use the template headings or provide explicit scope and approval details, but the required information is mostly present and the description is focused.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between d00f9d4 and d4795a8.
Files selected for processing: 1
scripts/personal-release.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XSvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Fix commits: 948a618 and cd85136. Related: #13.