镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(release): preserve ACP session adoption state - #14

Merged
Microck merged 2 commits into
personal-updatesfrom
fix/carry-acp-subscription-ref-20261104
Nov 4, 2026
Merged

Microck merged 2 commits into
personal-updatesfrom
fix/carry-acp-subscription-ref-20261104

Conversation

@Microck

@Microck Microck commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Carry the ACP session-adoption repair after the existing personal patches: use SubscriptionRef.set for observable config state.
  • Repair an Antigravity stop regression test that used the removed Crypto service; use SecureRandom as neighboring tests do.

Validation

  • Reproduced the adapter failure on generated snapshot 7a98834 before the fix.
  • With both fixes, all 19 non-browser carried-fix test commands passed locally: 882 test executions passed, with 205 filtered by the workflow's existing selectors. This includes the 132-test ACP adapter suite. Server, provider-acp, client-runtime and mobile typechecks passed; git diff --check passed.
  • The browser regression could not run locally: pinned Playwright Chromium download failed and system Chromium could not start in the environment, even on a second attempt. The web typecheck could not initialize its sandbox supervisor. Neither is represented as a pass. Hosted full release validation remains required before publication.

Fix commits: 948a618 and cd85136. Related: #13.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Nov 4, 2026
@Microck
Microck marked this pull request as ready for review November 4, 2026 06:29
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The personal release fix list now includes two additional commits. The existing release preparation flow processes both entries.

Changes: Personal release fixes

Layer / File(s) Summary
Add release fix entries
scripts/personal-release.ts
The fix list gains entries for updating observable ACP config state when adopting a session and using the current secure random service in the Antigravity stop test.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to d4795

The release-fix entries follow the existing processing contract and no merge-blocking risk remains.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary ACP session-adoption state fix. It uses an appropriate conventional commit format.
Description check Passed The description explains the two fixes, validation results, related issue, and known test limitations. It does not use the template headings or provide explicit scope and approval details, but the req…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the two fixes, validation results, related issue, and known test limitations. It does not use the template headings or provide explicit scope and approval details, but the required information is mostly present and the description is focused.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d00f9d4 and d4795a8.

Files selected for processing: 1
  • scripts/personal-release.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Microck commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Microck
Microck merged commit cd57426 into personal-updates Nov 4, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant