Repository navigation
Issue 32-character password reset codes - #1552
Draft
w3irdrobot wants to merge 1 commit into
Draft
w3irdrobot wants to merge 1 commit into
w3irdrobot wants to merge 1 commit into
Conversation
Raise emailed password reset codes (user and platform) from 8 to 32 uppercase alphanumeric characters. Move the generator out of AppState since it never used self, and add a unit test for length and charset. The Maple reset email showed the code with large, widely spaced type that a 32-character code would overflow. Render it at 18px with break-all wrapping instead, and drop the now-unused .code-lg rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
this builds on #1550. we should allow our frontends to be updated for a while before starting to dole our 32 character codes |
AnthonyRonning
requested changes
Nov 10, 2026
AnthonyRonning
left a comment
Contributor
There was a problem hiding this comment.
on hold for a few weeks at least
AnthonyRonning
marked this pull request as draft
November 10, 2026 19:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[A-Z0-9]).generate_alphanumeric_codemoves out ofAppStateinto a free function, since it never usedself, and gets a unit test for length and charset..code-lg), so a 32-character code would overflow the email. It now renders at 18px monospace withword-break: break-all, and the unused.code-lgrules are gone.Email verification codes are unchanged. They are already UUIDv4s (32 hex digits).
Rollout
min = 1.Validation
In
services/opensecret(nix develop .#ci):cargo fmt --all -- --check: passcargo clippy --locked --all-targets --all-features -- -D warnings: passcargo test --locked --all-features -- alphanumeric_code email::: 12 passed (new length test plus email template tests)Not run: the full backend test suite and DB integration tests, an end-to-end reset in a local stack, or rendering the email in a real mail client.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.