Repository navigation
Swap Params codeAction breaks code #3413
Description
How are you using the lua-language-server?
NeoVim
Which OS are you using?
MacOS
What is the issue affecting?
Formatting
Expected Behaviour
Write lua code in neovim with codeActions triggered on buffer save. The lua code looks like the following:
vim.api.nvim_create_autocmd('BufWritePre', {})and save, it will remain unchanged.
Actual Behaviour
It changes the code to the following:
vim.api.nvim_create_autocmd({}, 'BufWritePre')Reproduction steps
- Install lua-language-server
- Setup lua lsp in neovim (can expand if needed)
- Add the following autocmd to run codeactions on save
vim.api.nvim_create_autocmd('BufWritePre', {
group = vim.api.nvim_create_augroup('auto-format', { clear = false }),
buffer = ev.buf,
callback = function(evt)
local params = vim.lsp.util.make_range_params()
params.context = { }
local result = vim.lsp.buf_request_sync(evt.buf, "textDocument/codeAction", params)
for _, res in pairs(result or {}) do
for _, r in pairs(res.result or {}) do
if r.edit then
local enc = client.offset_encoding or "utf-16"
vim.lsp.util.apply_workspace_edit(r.edit, enc)
end
end
end
vim.lsp.buf.format({ bufnr = ev.buf, id = client.id, timeout_ms = 1000, async = false })
end,
})- Write some lua code and save that lua code with the cursor still on the same line.
Additional Notes
I was editing my neovim config and the lsp kept switching params like the following:
vim.api.nvim_create_autocmd('BufWritePre', {})And after my PreWrite autocmd calls codeActions
vim.api.nvim_create_autocmd({}, 'BufWritePre')which immediately breaks the code because the params are position sensitive.
It only does this if the cursor is on the line of the method call which I suppose makes sense since the code action is called with a range. My full autocmd works like this:
vim.api.nvim_create_autocmd('BufWritePre', {
group = vim.api.nvim_create_augroup('auto-format', { clear = false }),
buffer = ev.buf,
callback = function(evt)
local params = vim.lsp.util.make_range_params()
params.context = { }
local result = vim.lsp.buf_request_sync(evt.buf, "textDocument/codeAction", params)
for _, res in pairs(result or {}) do
for _, r in pairs(res.result or {}) do
if r.edit then
local enc = client.offset_encoding or "utf-16"
vim.lsp.util.apply_workspace_edit(r.edit, enc)
end
end
end
vim.lsp.buf.format({ bufnr = ev.buf, id = client.id, timeout_ms = 1000, async = false })
end,
})I narrowed it down to this code action here
Maybe I am holding it wrong and it is not supposed to be used in this way but I don't have a problem with other LSPs.
Log File
No log entry was added during this behaviour.
Activity
tanema commentedon May 28, 2026
I think maybe I am using it wrong but I also don't see any way here:
lua-language-server/script/core/code-action.lua
Lines 734 to 749 in b5e57c3