镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

libvisual-plugins: Base rotation on runtime not FPS for actor "lv_gltest" - #163

Merged
hartwork merged 1 commit into
masterfrom
improve-gltest-rotation
Jan 14, 2023
Merged

hartwork merged 1 commit into
masterfrom
improve-gltest-rotation

Conversation

@hartwork

@hartwork hartwork commented Jan 13, 2023 •

Copy link
Copy Markdown
Member

Similar to pull request #153 and #164 but for master.

@hartwork hartwork added this to the 0.5.0 milestone Jan 13, 2023
@hartwork
hartwork requested a review from kaixiong January 13, 2023 23:14

@kaixiong kaixiong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@kaixiong

Copy link
Copy Markdown
Member

Wait.. I think the timer needs to be destroyed with visual_timer_free().

@hartwork

Copy link
Copy Markdown
Member Author

Wait.. I think the timer needs to be destroyed with visual_timer_free().

@kaixiong good catch! Added now and also backported to 0.4.x in pull request #164.

@hartwork
hartwork requested a review from kaixiong January 14, 2023 00:18
@hartwork
hartwork merged commit c22a024 into master Jan 14, 2023
@hartwork
hartwork deleted the improve-gltest-rotation branch January 14, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants