Repository navigation
Fix DateTime::SetTime logging before initialized - #2396
Merged
Merged
Conversation
|
Build size and comparison to main:
|
Member
|
Hmm, I don't really like adding an extra argument to solve this. Could we defer the set time call to after logging is initialised? |
Contributor
Author
|
You're right, I think it's better this way |
mark9064
reviewed
Dec 31, 2025
mark9064
left a comment
Member
There was a problem hiding this comment.
Not sure why this method wasn't named correctly to begin with but otherwise all looks good :)
Good idea to move it to Utility as well
mark9064
approved these changes
Dec 31, 2025
Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
mark9064
force-pushed
the
fix-date-log
branch
from
November 2, 2026 23:56
f2be81e to
0333bfb
Compare
Member
|
Rebasing for fresh CI run |
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SetTimemethod is indirectly called by the global variable constructor inmain.cpp, which runs before the logger is initialized and thus crashes when trying to log a message. This doesn't affect release builds since logging is disabled there, but it does affect debug builds