Repository navigation
Update tsify - #4600
Open
0HyperCube wants to merge 1 commit into
Open
Update tsify#46000HyperCube wants to merge 1 commit into
0HyperCube wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Re-trigger cubic
0HyperCube
force-pushed
the
update-tsify
branch
2 times, most recently
from
September 25, 2026 15:41
3ffc488 to
638881a
Compare
0HyperCube
force-pushed
the
update-tsify
branch
from
October 1, 2026 11:50
638881a to
612f647
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the
#[tsify(into_wasm_abi, from_wasm_abi)]was deprecated in a patch release to avoid memory leaks when the type conversions fail. src: https://github.com/madonoharu/tsify#why-are-the-wasm_abi-attributes-deprecatedThe replacement involves passing a
Ts<MyStruct>orVec<Ts<MyStruct>>and then converting it in you rust code. An error message is logged if the conversions fail and the function returns early.This unfortunately requires further complicating the
#[editor_commands]macro.